Fixes for locked root account test #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1490
💛 - Coveralls |
atodorov
requested changes
Apr 9, 2019
Fixes related to a few issues in the locked root account test I somehow managed to overlook in the initial commit. Related: rhbz#1698473
jikortus
force-pushed
the
test-root-account-disabled-rhel8
branch
from
5a97ea1
to
ff6e15f
Compare
|
Covered by rhbz#1698473. |
atodorov
changed the title
|
@atodorov Yes, the same fixes are needed in the branches you mentioned, however the related PRs (PR681 and PR682) have already been merged. As for the labels - unfortunately it seems I'm not able to add them (possibly because I don't have write access to the repo?). |
|
@bcl this PR references a bug which is already in VERIFIED status. Are we OK to merge or we need a bug which is approved for the next release? Please check ! |
|
Yes, we need a new bug for the correct release. |
|
@atodorov The referenced bug in the commit message was fixed a few days ago (it has been updated to rhbz#1698473 that I filed for this purpose), but this change might have got somewhat lost among other comments. |
atodorov
changed the title
|
rhbz#1698473 is now approved. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes related to a few issues in the locked root account test I somehow managed to overlook in the initial commit.
Related: rhbz#1626122
--- Description of proposed changes ---
--- Merge policy ---
*-aws-runtestPASS*-azure-runtestPASS*-images-runtestPASS*-openstack-runtestPASS*-vmware-runtestPASSrhel8-*andrhel7-*branches commit log references an approvedbug in Bugzilla. Do not merge if the bug doesn't have the 3 ACKs set to
+!--- Jenkins commands ---
ok to testto accept this pull request for testingtest this pleasefor a one time test runretest this pleaseto start a new build