Backport repos.git to RHEL8 #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atodorov looks like the jenkins systems need to have python3-rpmfluff installed (and probably git as well). |
Pull Request Test Coverage Report for Build 1840
💛 - Coveralls |
This adds support, documentation, and testing for a [[repos.git]] blueprint section that can be used to install files from a git repository. It will create an rpm that will be added to the build, and included in the metadata that can be downloaded. This allows you to accurately keep track of the source of configuration files and extra metadata that is added to the build. The source repo and reference will be listed in the rpm's summary making it easy to discover on the installed system. (cherry picked from commit d7b96c8) Resolves: rhbz#1709594
This handles creating the rpm from the dictionary describing the repository and rpm. Also adds tests for archive and rpm creation. (cherry picked from commit f6f2308) Related: rhbz#1709594
This hooks up creation of the rpm to the build, adds it to the kickstart, and passes the url to Anaconda. The dnf repo with the rpms is created under the results directory so it will be included when downloading the build's results. (cherry picked from commit cd8c884) Related: rhbz#1709594
The freeze function was not being tested. Add a test for it using the repos.git test recipe. (cherry picked from commit c26477a) Related: rhbz#1709594
Log them and report them as RuntimeError. Also add a couple tests for them. (cherry picked from commit 61efa91) Related: rhbz#1709594
This way it can be shared with test_server.py (cherry picked from commit 02f757d) Related: rhbz#1709594
- Check final-kickstart.ks for the rpm source - Check final-kickstart.ks for the rpm package name and version - Make sure depsolve works - Make sure errors from a bad repo are returned correctly - Make sure errors from a bad reference are returned correctly This moves _wait_for_status into a helper function so it can be shared between the test classes. (cherry picked from commit 8c2184d) Related: rhbz#1709594
rpmfluff was including / in the rpm, which conflicts with filesystem.rpm The rpm globs are pretty limited, and we don't actually know the file paths until later, so we have to use a glob or a directory. So when the destination is / it now uses /* to select all the files and sub-directories in the archive. The limitation of this is that it cannot support dotfiles directly under /, they will cause a rpmbuild error. For destinations other than / it uses the name of the directory, so dotfiles are fine in that situation. (cherry picked from commit 049f68c) Related: rhbz#1709594
Make sure that dotfiles are installed when not directly under / Make sure / is not packaged in the rpm (it will cause a conflict with the filesystem package). Make sure that using destination="/" works (cherry picked from commit 6fd06c6) Related: rhbz#1709594
Fixes weldr#771 Related: rhbz#1709594 Signed-off-by: Brian C. Lane <bcl@redhat.com>
Related: rhbz#1709594 Signed-off-by: Brian C. Lane <bcl@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.