Windows fixes and CI #148
Merged
Windows fixes and CI #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The golden tests fail in Windows because of not enough normalization |
Collaborator
Author
|
and the DAP proxy test does file handle things which don't seem to work on windows. Let's disable that test on Windows for now. |
alt-romes
force-pushed
the
wip/romes/windows-ci
branch
5 times, most recently
from
e8629ac to
b307e9b
Compare
alt-romes
force-pushed
the
wip/romes/windows-ci
branch
from
b307e9b to
ce9c9c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146
Fixes #147