Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug that arises during server rendering #49

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@jigarjain
Copy link
Contributor

commented Jul 23, 2019

When server rendering the React app, we get a fatal mode not found on undefined property. This PR fixes that

fix bug that arises during server rendering
When server rendering the React app, we get a fatal `mode` not found on undefined property. This PR fixes that
@jigarjain

This comment has been minimized.

Copy link
Contributor Author

commented on f751bbb Jul 23, 2019

This should fix the issue #48. Please let me know if there is something more that I can help with to get this out. I believe currently this library would break for all server-side rendered apps. @vzaidman

@vzaidman vzaidman merged commit f4059ff into welldone-software:master Jul 23, 2019

@vzaidman

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.