-
-
Notifications
You must be signed in to change notification settings - Fork 403
Add an option to show violation shortlinks in the formatter output #2375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sobolevn I'm currently looking at how testing is done for the formatter. Should I just add a variation to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
How should we deal with |
Also, any ideas how to get that last 1% of coverage for Apparently it has to do with this piece of code – I've taken it verbatim from |
I think that |
|
Now it should be fine! 👍 |
Codecov Report
@@ Coverage Diff @@
## master #2375 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 120 120
Lines 6394 6408 +14
Branches 1442 1445 +3
=========================================
+ Hits 6394 6408 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, great feature!
I also think that adding --violation-links-prefix=
is a good idea.
So, users can change services:
--violation-links-prefix=https://ya.ru
will result inhttps://ya.ru/WPS001
- etc
If you are interested, you can send one more PR.
Bery big thanks for your work and financial support! 👍
Checklist
CHANGELOG.md
Related issues
Closes #2374