Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] le style du navbar ne correspond pas au figma #22

Closed
mascot27 opened this issue Apr 14, 2021 · 4 comments
Closed

[BUG] le style du navbar ne correspond pas au figma #22

mascot27 opened this issue Apr 14, 2021 · 4 comments
Assignees
@WenesLimem
Labels
bug Something isn't working visual
Milestone
Sprint 3

Comments

@mascot27
Copy link
Collaborator

A retravailler
@mascot27 mascot27 added bug Something isn't working visual labels Apr 14, 2021
@mascot27 mascot27 added this to the Sprint 3 milestone Apr 14, 2021
@mascot27
Copy link
Collaborator Author

Exemple typique de pourquoi il faut un reviewer

@mascot27
Copy link
Collaborator Author

mascot27 commented Apr 14, 2021 •
edited
Loading

Les nom ne correspondent pas
image

@mascot27 mascot27 pinned this issue Apr 14, 2021
@WenesLimem WenesLimem unpinned this issue Apr 15, 2021
@WenesLimem WenesLimem mentioned this issue Apr 17, 2021
Merged
@mascot27
Copy link
Collaborator Author

mascot27 commented Apr 17, 2021 •
edited
Loading

Pas résolu:

  • pour la nav bar complique toi pas, tu fais une border a droite generale et on a pas de ligne entre les onglets,
  • apres il y a aussi vite fais que le avatar il a une image pas top mais on modifiera ca avec l'arrivée des users
  • il faut une ligne entre la bar du haut et l'app, une border 1px solid suffit a mon avis
  • Il faut que l'on puisse cliquer sur toute la largeur de la bar navigation pour aller dans les onglets
  • lorsque on est dans l'onglet, mettre l'icone en orange (primary) afin de donner un feedback au user

⚠️ Merci de relire le guide de contribution ⚠️

@WenesLimem
Copy link
Owner

#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WenesLimem WenesLimem

Labels
bug Something isn't working visual
Projects
None yet
Milestone
Sprint 3
Development

No branches or pull requests
2 participants
@mascot27 @WenesLimem