New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build libxslt and libxml on travis. Use what's available #98

Merged
merged 1 commit into from Aug 9, 2016

Conversation

Projects
None yet
2 participants
@jcoyne
Contributor

jcoyne commented Aug 9, 2016

No description provided.

@weppos

This comment has been minimized.

Show comment
Hide comment
@weppos

weppos Aug 9, 2016

Owner

Please explain the reason of this patch

Owner

weppos commented Aug 9, 2016

Please explain the reason of this patch

@jcoyne

This comment has been minimized.

Show comment
Hide comment
@jcoyne

jcoyne Aug 9, 2016

Contributor

Travis CI has libxslt and libxml already compiled. If you provide this environment variable, then nokogiri will be built using those already compiled libraries. If you don't provide this environment variable, nokogiri will compile those libraries itself, before building nokogiri. This takes a not insignificant amount of time. So this patch speeds up the travis build and is nice to travis because we use less of their computing resources.

Contributor

jcoyne commented Aug 9, 2016

Travis CI has libxslt and libxml already compiled. If you provide this environment variable, then nokogiri will be built using those already compiled libraries. If you don't provide this environment variable, nokogiri will compile those libraries itself, before building nokogiri. This takes a not insignificant amount of time. So this patch speeds up the travis build and is nice to travis because we use less of their computing resources.

@weppos

This comment has been minimized.

Show comment
Hide comment
@weppos

weppos Aug 9, 2016

Owner

Thanks! 👍

Owner

weppos commented Aug 9, 2016

Thanks! 👍

@weppos weppos merged commit 714de60 into weppos:master Aug 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment