Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Mar 24, 2015
  1. Release 1.5.0

    authored
Commits on Feb 14, 2015
  1. Test against Ruby 2.2

    authored
  2. 2015!

    authored
  3. Merge pull request #65 from postmodern/cleanups

    authored
    Cleanups
  4. @postmodern

    Use Array#compact.

    postmodern authored
  5. @postmodern

    Removed double empty lines.

    postmodern authored
  6. @postmodern

    Fixed yardoc options.

    postmodern authored
  7. @postmodern
  8. @postmodern

    Fixed YARD param.

    postmodern authored
  9. @postmodern
  10. @postmodern

    Use instance variables.

    postmodern authored
  11. @postmodern

    Use attr_readers.

    postmodern authored
  12. @postmodern
  13. @postmodern
  14. @postmodern
  15. @postmodern

    Make Rule a module.

    postmodern authored
  16. @postmodern
  17. @postmodern
  18. @postmodern

    Fixed indentation.

    postmodern authored
  19. @postmodern
  20. @postmodern
  21. @postmodern
  22. @postmodern

    Make the regexp more clear.

    postmodern authored
Commits on Dec 3, 2014
  1. Merge pull request #58 from raeno/select_first_to_detect

    authored
    Use Enumerable#detect instead of select+first combo.
Commits on Dec 2, 2014
  1. @raeno

    Use Enumerable#detect ( http://ruby-doc.org/core-2.1.5/Enumerable.htm…

    raeno authored
    …l#method-i-detect ) instead of select+first combo.
    
    It's faster since it stop iterating on first match.
Commits on Nov 23, 2014
  1. ruby examples

    authored
  2. Minitest is causing too much pain

    authored
    Revert back to Test:Unit. Minutest is failing on Ruby 1.9.3, jRuby
    1.9.3 and Ruby head.
  3. Ignore jruby

    authored
  4. Update definitions

    authored
  5. Dropped support for Ruby < 2.0

    authored
  6. More domain validation use cases

    authored
    (closes GH-41, references GH-57)
  7. Merge pull request #57 from weppos/domain-validation

    authored
    Domain validation use cases
  8. Add validation false positive

    authored
    This is a list of cases where PublicSuffix.valid? returns true and the
    domain is apparently invalid.
    
    - Domain has a scheme :// (GH-15, GH-33)
    - Domain contains spaces (GH-52)
    - Domain contains double (GH-25, GH-36)
    
    This is an hard decision to make, but as I explained more than one, the
    purpose of this library is not to formally validate the syntax of a
    domain or an URI.
    
    The library expects the input to be a domain, and can't run all the
    possible guesses and checks to guarantee the input. This is a
    constraint that the caller must ensure. Entering the business of
    validating URIs would make the maintenance of this library very
    complicated.
    
    This is an example of a simple validation that could be used before
    submitting the string for tokenisation.
    
    def valid_uri?(name)
    uri = URI.parse(name)
    uri.host != nil
    rescue
    false
    end
    
    I don't exclude to add such filter in the future in the `#valid?`
    method, may be as wrapper for the current `valid?` behaviour. But for
    the time being, this library is not intended to formally validate URIs
    or domains.
    
    (closes GH-25, closes GH-36, closes GH-52)
  9. Remove useless constants

    authored
  10. Switch to minitest

    authored
Something went wrong with that request. Please try again.