Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need help understanding PublicSuffix::DomainNotAllowed #141

Closed
jaredmcqueen opened this issue Jun 16, 2017 · 1 comment

Comments

@jaredmcqueen
Copy link

commented Jun 16, 2017

ignore_private: true for "example.s3.amazonaws.com"

tld: com
sld: amazonaws
trd: example.s3
domain: amazonaws.com
subdomain: example.s3.amazonaws.com

ignore_private: false for "example.s3.amazonaws.com"

    PublicSuffix::DomainNotAllowed: example.s3.amazonaws.com is not allowed according to Registry policy

I understand s3.amazonaws.com is in the private section of the list, but it behaves differently than other entries also in the private section - like blogspot.com. example.blogspot.com should behave identically, but it doesn't. Why would I get the DomainNotAllowed exception on one private entry, but not another?

@weppos

This comment has been minimized.

Copy link
Owner

commented Aug 4, 2017

It depends on the version of the list you are running, but I assume the issue you are facing is because your list (which is likely the one packaged with the release 2.0.5) contains

*.s3.amazonaws.com

That causes the hostname you provided to be invalid. There is no such wildcard for blogspot.

@weppos weppos closed this Aug 4, 2017

@weppos weppos added the question label Aug 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.