Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention utils/mkwhois.rb in CONTRIBUTING.md #4

Merged
merged 2 commits into from Dec 4, 2015

Conversation

@mpchadwick
Copy link
Contributor

@mpchadwick mpchadwick commented Dec 3, 2015

Fixes weppos/whois#461

@@ -24,6 +24,10 @@ Make your change. Add tests for your change. Make the tests pass:

$ bundle exec rake

`utils/mkwhois.rb` can be used to quicky generate `status_available.txt` and `status_registered.txt` files for your tests

$ ruby utils/mkwhois.rb google.com status-available
Copy link
Owner

@weppos weppos Dec 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change this line to use the underscore. I'd also add a path to the file

$ ruby utils/mkwhois.rb google.it it/status_available

Loading

Copy link
Contributor Author

@mpchadwick mpchadwick Dec 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the hypen was a typo, will update. #3 will automatically create the path, so don't think that's necessary.

Loading

Copy link
Owner

@weppos weppos Dec 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree.

Loading

weppos added a commit that referenced this issue Dec 4, 2015
Mention utils/mkwhois.rb in CONTRIBUTING.md
@weppos weppos merged commit d3f7ea2 into weppos:master Dec 4, 2015
1 check failed
Loading
@weppos weppos self-assigned this Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants