Skip to content

Mention utils/mkwhois.rb in CONTRIBUTING.md#4

Merged
weppos merged 2 commits intoweppos:masterfrom
mpchadwick:contributing-mkwhois-note
Dec 4, 2015
Merged

Mention utils/mkwhois.rb in CONTRIBUTING.md#4
weppos merged 2 commits intoweppos:masterfrom
mpchadwick:contributing-mkwhois-note

Conversation

@mpchadwick
Copy link
Copy Markdown
Contributor

Comment thread CONTRIBUTING.md Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change this line to use the underscore. I'd also add a path to the file

$ ruby utils/mkwhois.rb google.it it/status_available

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the hypen was a typo, will update. #3 will automatically create the path, so don't think that's necessary.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree.

weppos added a commit that referenced this pull request Dec 4, 2015
Mention utils/mkwhois.rb in CONTRIBUTING.md
@weppos weppos merged commit d3f7ea2 into weppos:master Dec 4, 2015
@weppos weppos self-assigned this Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants