Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention utils/mkwhois.rb in #4

merged 2 commits into from Dec 4, 2015


Copy link

commented Dec 3, 2015

@@ -24,6 +24,10 @@ Make your change. Add tests for your change. Make the tests pass:

$ bundle exec rake

`utils/mkwhois.rb` can be used to quicky generate `status_available.txt` and `status_registered.txt` files for your tests

$ ruby utils/mkwhois.rb status-available

This comment has been minimized.

Copy link

weppos Dec 3, 2015


I'd change this line to use the underscore. I'd also add a path to the file

$ ruby utils/mkwhois.rb it/status_available

This comment has been minimized.

Copy link

mpchadwick Dec 4, 2015

Author Contributor

Ah, the hypen was a typo, will update. #3 will automatically create the path, so don't think that's necessary.

This comment has been minimized.

Copy link

weppos Dec 4, 2015


Yes, I agree.

weppos added a commit that referenced this pull request Dec 4, 2015

Merge pull request #4 from mpchadwick/contributing-mkwhois-note
Mention utils/mkwhois.rb in

@weppos weppos merged commit d3f7ea2 into weppos:master Dec 4, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed

@weppos weppos self-assigned this Dec 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.