Handle response format changes noisily #38

Closed
DerGuteMoritz opened this Issue Sep 22, 2010 · 1 comment

Comments

Projects
None yet
2 participants

I just noticed that the DENIC changed its response format by wondering why a certain domain got returned as unavailable (nil). Thanks for the quick update of the respective parser, Simone! However, to handle situations like this, it might make more sense to fail more noisily than just returning nil. Maybe by raising exceptions? What do you think?

Owner

weppos commented Sep 22, 2010

You're right DerGuteMoritz.

The problem is that, currently, there isn't a real validation system in place to make sure we're dealing with the expected response format.

For maintainers that includes the format version in the response, like denic does, I'm planning to add a validation system in the future. Talking about denic, they just introduced a major problem: they are skipping format version when a domain is invalid or unavailable, which introduces additional complexity.

On the other side, I already started to add a more restrictive validation in some circumstances. For instance, some parsers already raises an exception when they found an unknown #status string, instead of silently returning a default value.

However, this is not a small issue and I need more time to find a comprehensive solution and apply it.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment