Update whois.nic.lv parser #146

Merged
merged 5 commits into from Feb 3, 2012

Conversation

Projects
None yet
2 participants
@priithaamer
Contributor

priithaamer commented Jan 31, 2012

The whois.nic.lv server response format has been changed. This is the minimal change to check the availability of .lv domains. Fixes #145

Priit Haamer
Update whois.nic.lv parser
The whois.nic.lv server response format has been changed. This is the minimal change to check the availability of .lv domains. Fixes #145
lib/whois/record/parser/whois.nic.lv.rb
class WhoisNicLv < Base
property_supported :status do
if available?
- :available

This comment has been minimized.

Show comment Hide comment
@weppos

weppos Jan 31, 2012

Owner

Please use available and registered.
See 6083c97#lib/whois/record/parser/whois.smallregistry.net.rb-P13

lib/whois/record/parser/whois.nic.lv.rb
# = whois.nic.lv parser
#
# Parser for the whois.nic.lv server.
- #

This comment has been minimized.

Show comment Hide comment
@weppos

weppos Jan 31, 2012

Owner

Do not remove the NOTE paragraph unless you implement all the supported parser methods (such as contact parsing).

@weppos

weppos Jan 31, 2012

Owner

Do not remove the NOTE paragraph unless you implement all the supported parser methods (such as contact parsing).

@priithaamer

This comment has been minimized.

Show comment Hide comment
@priithaamer

priithaamer Jan 31, 2012

Contributor

Do you prefer to update .gemspec by yourself?

Contributor

priithaamer commented Jan 31, 2012

Do you prefer to update .gemspec by yourself?

@@ -7,7 +7,6 @@
#registered?
should: %s == true
-

This comment has been minimized.

Show comment Hide comment
@weppos

weppos Jan 31, 2012

Owner

The separator exists to group properties by scope. Please restore line 10 and 21.

@weppos

weppos Jan 31, 2012

Owner

The separator exists to group properties by scope. Please restore line 10 and 21.

@weppos

This comment has been minimized.

Show comment Hide comment
@weppos

weppos Jan 31, 2012

Owner

Yes, I'll update it.

Please also rename the fixture files to use status_available instead of free.
Also it seems the status_free.expected file no longer includes the test for nameservers.

Owner

weppos commented Jan 31, 2012

Yes, I'll update it.

Please also rename the fixture files to use status_available instead of free.
Also it seems the status_free.expected file no longer includes the test for nameservers.

lib/whois/record/parser/whois.nic.lv.rb
Time.parse($1.split(" ", 2).last)
end
end
property_not_supported :expires_on
-

This comment has been minimized.

Show comment Hide comment
@weppos

weppos Jan 31, 2012

Owner

Please don't remove extra lines 46 and 57, they exists to group methods by scope.

@weppos

weppos Jan 31, 2012

Owner

Please don't remove extra lines 46 and 57, they exists to group methods by scope.

@priithaamer

This comment has been minimized.

Show comment Hide comment
@priithaamer

priithaamer Jan 31, 2012

Contributor

Thanks for the feedback. Makes sense.

Contributor

priithaamer commented Jan 31, 2012

Thanks for the feedback. Makes sense.

@@ -6,18 +6,3 @@
#registered?
should: %s == false
-
-
-#created_on

This comment has been minimized.

Show comment Hide comment
@weppos

weppos Jan 31, 2012

Owner

One more change, the last one.

Whey did you remove created_on, updated_on, expires_on and nameservers properties? ;)

@weppos

weppos Jan 31, 2012

Owner

One more change, the last one.

Whey did you remove created_on, updated_on, expires_on and nameservers properties? ;)

weppos added a commit that referenced this pull request Feb 3, 2012

Merge pull request #146 from priithaamer/whois.nic.lv
Update whois.nic.lv parser (closes GH-145)

@weppos weppos merged commit 5f5483c into weppos:master Feb 3, 2012

weppos added a commit that referenced this pull request Feb 3, 2012

@ghost ghost assigned weppos Feb 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment