I fixed the parser for Godaddy #148

Merged
merged 1 commit into from Feb 16, 2012

2 participants

@hadees

The Godaddy parser was broken. It looks like Godaddy updated what they respond with.

As part of this though I removed the url param but I was wondering what the problem with just hard coding it was?

Additionally I had some questions about what exactly property_dates_not_available.txt is and how you were generating the status_registered.txt files. Is there anyway to auto update them so we know which parsers are broken?

I'd like to start writing some more parsers, maybe you can give me an overview of how you want me to write them?

@weppos
Owner

Apparently, GoDaddy Inc. become Go Daddy Operating Company, LLC.

I was wondering what the problem with just hard coding it was?

If an URL is present, using that URL reduces the number of possible errors. In this case, I would hard-code it when the Registrar record is created.

Record::Registrar.new(...)

Additionally I had some questions about what exactly property_dates_not_available.txt is and how you were generating the status_registered.txt files.

I use the mkwhois tool to generate these files.

./utils/mkwhois godaddy.com status_registered.txt

Bear in mind that, in case of multi-part WHOIS servers (such as .COM, .NET) a status_registered.txt response will be created for each server (in this case Verisign e GoDaddy). Make sure to discard the former.

Is there anyway to auto update them so we know which parsers are broken?

Not at the current state. I have been considering writing a kind of continuous integration system for this, but there's nothing available for now.

@weppos weppos merged commit 1fe2a80 into weppos:master Feb 16, 2012
@weppos weppos was assigned Feb 16, 2012
@weppos weppos added a commit that referenced this pull request Feb 16, 2012
@weppos Update changelog for GH-148 e06ce05
@hadees hadees added a commit to hadees/whois that referenced this pull request Feb 17, 2012
@weppos Update changelog for GH-148 203c0d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment