Update parser for .ru having different entries #150

Merged
merged 1 commit into from Jul 4, 2012

2 participants

@semaperepelitsa

Now most of the contact info has gone but there is an url to the contact form. SU domains still have email and other contact fields.

Note that I've added Contact#url attribute.

@semaperepelitsa semaperepelitsa Update parser for .ru having different entries
Now most of the contact info has gone but there is an url to the contact form.
17deaf4
@weppos weppos commented on the diff Mar 5, 2012
...sponses/whois.tcinet.ru/ru/status_registered.expected
should: %s[0] CLASS(contact)
should: %s[0].type == Whois::Record::Contact::TYPE_ADMIN
- should: %s[0].id == nil
@weppos
Owner
weppos added a line comment Mar 5, 2012

Instead of removing the properties, please set them to nil. In this way we force the test to test against empty properties to avoid the parser would crash trying to call any of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@weppos weppos was assigned May 11, 2012
@weppos weppos was assigned Jul 4, 2012
@weppos weppos merged commit f2f127d into weppos:master Jul 4, 2012
@weppos weppos added a commit that referenced this pull request Jul 4, 2012
@weppos Update CHANGELOG for GH-150 ca22aeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment