Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed whois.rnids.rs parser not to split nameserver name at the hypen #164

Merged
merged 1 commit into from May 20, 2012

Conversation

Projects
None yet
2 participants
Contributor

sherwind commented May 11, 2012

No description provided.

Owner

weppos commented May 11, 2012

As far as I know, the current implementation should already cover this case. Did you experience any issue?

@weppos weppos was assigned May 11, 2012

Contributor

sherwind commented May 12, 2012

The current implementation has a problem with nameserver name that contains hyphen

1.9.3-p0 :019 > r = Whois.query("eg.rs")

1.9.3-p0 :020 > r.nameservers.first.name
 => "bits" 

1.9.3-p0 :021 > r.nameservers.last.name
 => "largo.bitsyu.net"

1.9.3-p0 :022 > "bits-hq.bitsyu.net. - 217.24.17.10".split("-").map(&:strip)
 => ["bits", "hq.bitsyu.net.", "217.24.17.10"] 
Owner

weppos commented May 12, 2012

Ops, you are right. I haven't considered hypens in the hostname.

Thanks, I'll merge it soon.

-- Simone

On Sat, May 12, 2012 at 7:38 AM, Sherwin Daganato <
reply@reply.github.com

wrote:

The current implementation has a problem with nameserver name that
contains hyphen

1.9.3-p0 :019 > r = Whois.query("eg.rs")

1.9.3-p0 :020 > r.nameservers.first.name
=> "bits"

1.9.3-p0 :021 > r.nameservers.last.name
=> "largo.bitsyu.net"

1.9.3-p0 :022 > "bits-hq.bitsyu.net. -
217.24.17.10".split("-").map(&:strip)
=> ["bits", "hq.bitsyu.net.", "217.24.17.10"]


Reply to this email directly or view it on GitHub:
#164 (comment)

Simone Carletti
Application Developer

Site & Blog: http://www.simonecarletti.com
Email: weppos@weppos.net
LinkedIn: http://linkedin.com/in/weppos
Skype: weppos

@weppos weppos added a commit that referenced this pull request May 20, 2012

@weppos weppos Merge pull request #164 from sherwind/rs-nameservers-hyphenated
Fixed whois.rnids.rs parser not to split nameserver name at the hypen
c1bae6c

@weppos weppos merged commit c1bae6c into weppos:master May 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment