Added a whois.networksolutions.com parser. #167

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@bramp
Contributor

bramp commented May 28, 2012

Parses most of the info, and has test cases.

+ property_not_supported :status
+
+ # The server is contacted only in case of a registered domain.
+ property_not_supported :available?

This comment has been minimized.

@weppos

weppos May 28, 2012

Owner

Please list the properties as supported, with a hard-coded value.

# The server is contacted only in case of a registered domain.
property_supported :available? do
  false
end

property_supported :registered? do
  !available?
end
@weppos

weppos May 28, 2012

Owner

Please list the properties as supported, with a hard-coded value.

# The server is contacted only in case of a registered domain.
property_supported :available? do
  false
end

property_supported :registered? do
  !available?
end
+ property_not_supported :available?
+ property_not_supported :registered?
+
+ property_not_supported :registrar

This comment has been minimized.

@weppos

weppos May 28, 2012

Owner

Please set a hard-coded value. We already know this is Networksolution.

property_supported :registrar do
  Record::Registrar.new(
      :name => 'Network Solutions',
      :organization => 'Network Solutions, LLC',
      :url  => 'http://www.networksolutions.com/'
  )
end
@weppos

weppos May 28, 2012

Owner

Please set a hard-coded value. We already know this is Networksolution.

property_supported :registrar do
  Record::Registrar.new(
      :name => 'Network Solutions',
      :organization => 'Network Solutions, LLC',
      :url  => 'http://www.networksolutions.com/'
  )
end
+# An intelligent pure Ruby WHOIS client and parser.
+#
+# Copyright (c) 2009-2012 Simone Carletti <weppos@weppos.net>
+# Copyright (c) 2012 Andrew Brampton <me@bramp.net>

This comment has been minimized.

@weppos

weppos May 28, 2012

Owner

Please don't change the global copyright. Use the @author tag in the class.

Here's an example
https://github.com/weppos/whois/blob/master/lib/whois/record/parser/whois.co.ug.rb#L26-27

@weppos

weppos May 28, 2012

Owner

Please don't change the global copyright. Use the @author tag in the class.

Here's an example
https://github.com/weppos/whois/blob/master/lib/whois/record/parser/whois.co.ug.rb#L26-27

+ should: %s CLASS(array)
+ should: %s SIZE(3)
+ should: %s[0] CLASS(nameserver)
+ should: %s[0] == _nameserver.new(:name => "NS01.XIF.COM", :ipv4 => "63.240.200.70")

This comment has been minimized.

@weppos

weppos May 28, 2012

Owner

Please separate the properties. Use

should: %s[0].name == "NS01.XIF.COM"
should: %s[0].ipv4 =="63.240.200.70"

instead of

should: %s[0] == _nameserver.new(:name => "NS01.XIF.COM", :ipv4 => "63.240.200.70")

Also keep in mind nameserver names should always be lower case in the output.

@weppos

weppos May 28, 2012

Owner

Please separate the properties. Use

should: %s[0].name == "NS01.XIF.COM"
should: %s[0].ipv4 =="63.240.200.70"

instead of

should: %s[0] == _nameserver.new(:name => "NS01.XIF.COM", :ipv4 => "63.240.200.70")

Also keep in mind nameserver names should always be lower case in the output.

@weppos

This comment has been minimized.

Show comment
Hide comment
@weppos

weppos May 28, 2012

Owner

Thanks for the patch, Andrew.

It looks great! I just posted a few notes.

-- Simone

Owner

weppos commented May 28, 2012

Thanks for the patch, Andrew.

It looks great! I just posted a few notes.

-- Simone

@weppos

This comment has been minimized.

Show comment
Hide comment
@weppos

weppos May 28, 2012

Owner

Duplicates #168

Owner

weppos commented May 28, 2012

Duplicates #168

@weppos weppos closed this May 28, 2012

@ghost ghost assigned weppos Nov 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment