Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added a parser for whois.networksolution.com. #168

Merged
merged 2 commits into from Jun 5, 2012

Conversation

Projects
None yet
2 participants
Contributor

bramp commented May 28, 2012

Second attempt at sending over the networksolutions parser.

Owner

weppos commented May 28, 2012

Thanks! The status_available.txt file is missing the corresponding .expected test.

Also, once you have both .expected files, make sure to generate the tests and run them.

$ rake spec:generate
$ rake

The test suite will run and output any parser error.

Owner

weppos commented May 28, 2012

Actually, the status_available.expected file is not required since the parser is never invoked on unavailable domains.

You have two choices:

  1. delete the status_available.txt file
  2. implement the support for the status_available response (and provide the .expected file)

weppos added a commit that referenced this pull request Jun 5, 2012

Merge pull request #168 from bramp/whois.networksolutions.com
Added a parser for whois.networksolution.com.

@weppos weppos merged commit a7c16c3 into weppos:master Jun 5, 2012

Owner

weppos commented Jun 5, 2012

Merged, thank you. I had to apply some changes and generate the tests that haven't been generated.

weppos added a commit that referenced this pull request Jun 5, 2012

Update fixtures for whois.networksolutions.com (references GH-168).
Make sure the fixture contains the full response, not just a portion.

weppos added a commit that referenced this pull request Jun 5, 2012

$ rake spec:generate
and fix broken tests (references GH-168).

weppos added a commit that referenced this pull request Jun 5, 2012

@ghost ghost assigned weppos Nov 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment