Please check out the additional methods implementation for the following whois server parsers: #198

Closed
wants to merge 27 commits into
from

3 participants

@yangsec888
  1. whois.nic.tel.rb
  2. whois.aeda.net.ae.rb

Any comments on the coding style and skill improvement would be appreciated, as I'm a newbie to Ruby.

Thank you for creating and maintaining this wonderful project.

Regards,
Yang Li

yangsec888 added some commits Jan 15, 2013
@yangsec888 yangsec888 changes by the newbie - Yang on Dec 2012 336377f
@yangsec888 yangsec888 change to whois.nic.tel.rb 8efcf57
@yangsec888 yangsec888 change to whois.sgnic.sg.rb 674ea5e
@yangsec888 yangsec888 modification to accomodate new properties defined within whois.crsnic…
….net.rb
e25794c
@yangsec888 yangsec888 add container for billing info afb8b08
@yangsec888 yangsec888 add container for billing info bd4f536
@yangsec888 yangsec888 modify whois.hkirc.hk.rb f844545
@yangsec888 yangsec888 change of whois.hkirc.hk.rb f08d731
@yangsec888 yangsec888 change to whois.cnnic.cn.rb 7e23eb5
@yangsec888 yangsec888 build_contact method bugfix for the parser whois.hkirc.hk.rb 0bc4322
@yangsec888 yangsec888 Implement new methods for parser whois.nic.us.rb 4c6c7b9
@yangsec888 yangsec888 Implement new methods for parser whois.dns.pt.rb 3000bae
@yangsec888 yangsec888 new methods in parser whois.jprs.jp.rb ac5b1ee
@yangsec888 yangsec888 implemenet new methods in parser whois.twnic.net.tw.rb 33edc45
@yangsec888 yangsec888 implement new methods on parser whois.nic.ch.rb be954f4
@yangsec888 yangsec888 Expand registrar data structure; implement new methods in parser whoi…
…s.dns.lu.rb
eecf627
@yangsec888 yangsec888 implement new methods in parser whois.dk-hostmaster.dk.rb 3734b71
@yangsec888 yangsec888 implement new methods in the parser whois.nic.ve.rb a29994d
@yangsec888 yangsec888 implement new methods in parser whois.nic.ly.rb 622a7bc
@yangsec888 yangsec888 implement new methods in parser whois.kenic.or.ke.rb 0c9fcd0
@yangsec888 yangsec888 implement new methods in parser whois.nic.at.rb c1dd433
@yangsec888 yangsec888 Implement new methods for the parser whois.nic.at.rb 3b2985d
@yangsec888 yangsec888 Implement new methods for the parser whois.ai.rb 4f84cbc
@yangsec888 yangsec888 Implement new methods for the parser whois.nic.mx.rb bd0ff48
@yangsec888 yangsec888 Implement new methods for the parser whois.domainregistry.my.rb c1afd9b
@yangsec888 yangsec888 Implement new methods for the parser whois.nic.tr.rb 890cd45
@yangsec888 yangsec888 Implement new methods for the parser whois.domain.kg.rb 294cc85
@weppos
Owner

Thank you for the patch!

Unfortunately, I cannot accept it in the current format for the following reasons:

  1. Every method and every property must have a test associated
  2. The patch doesn't pass the build
  3. The patch includes several changes other than the scope of the patch message
  4. The patch doesn't respect the Ruby syntax conventions (especially about spacing and naming)

I suggest you to create a branch for every feature-set and submit smaller patches, taking into consideration the requirements listed above.

@weppos weppos closed this Feb 5, 2013
@coveralls

Coverage Status

Changes Unknown when pulling 294cc85 on yangsec888:master into ** on weppos:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment