Fix adapters from JSON definitions being ignored. #203

merged 1 commit into from Feb 5, 2013


None yet
2 participants

linrock commented Feb 5, 2013

All whois queries currently just use the Standard adapter since Whois::Server.factory looks for the adapter option as a symbol, but JSON parses keys as strings by default. Fixed so that the proper adapters are used again.


weppos commented Feb 5, 2013

Thanks @linrock for pointing it out!

weppos merged commit dd56b67 into weppos:master Feb 5, 2013

1 check passed

default The Travis build passed

@weppos weppos added a commit that referenced this pull request Feb 5, 2013

@weppos weppos Convert options to Symbol when loading the JSON.
Alternative solution to GH-203.

weppos commented Feb 5, 2013

@linrock I changed the implementation a little bit to convert the options when the file is loaded (to save memory) and I added a test.

Thanks for reporting the issue.


linrock commented Feb 5, 2013

Sounds good! Just needed to get a quick fix in to pave way for #204.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment