Fix adapters from JSON definitions being ignored. #203

Merged
merged 1 commit into from Feb 5, 2013

2 participants

@linrock

All whois queries currently just use the Standard adapter since Whois::Server.factory looks for the adapter option as a symbol, but JSON parses keys as strings by default. Fixed so that the proper adapters are used again.

@weppos
Owner

Thanks @linrock for pointing it out!

@weppos weppos merged commit dd56b67 into weppos:master Feb 5, 2013

1 check passed

Details default The Travis build passed
@weppos weppos added a commit that referenced this pull request Feb 5, 2013
@weppos Convert options to Symbol when loading the JSON.
Alternative solution to GH-203.
ef589d3
@weppos
Owner

@linrock I changed the implementation a little bit to convert the options when the file is loaded (to save memory) and I added a test.

Thanks for reporting the issue.

@linrock

Sounds good! Just needed to get a quick fix in to pave way for #204.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment