Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add support expires of attribute-type jp domain #301

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Owner

weppos commented Feb 12, 2014

Hello @akagisho, the link you posted is in Japanese. Is there an English version?

Please note that you should not change the spec file directly, as described in the header at the top of the file.
https://github.com/akagisho/whois/blob/support_attribute_type_jp_domain/spec/whois/record/parser/responses/whois.jprs.jp/ne.jp/status_registered_spec.rb#L3-L11

Would you mind to fix the commit?

One more question. It's not clear to me why you changed the whois fixtures. Did you regenerate them you, or did you simply manually change them?

Hi @weppos,

Is there an English version?

Unfortunately I couldn't find an English version.
This page describes the expiration date of attribute-type JP domain names.
"attribute" means a second label which consists of two characters.
For example, "co", "ne", et al.

Currently your module cannot find the expiration date of attribute-type JP domains.

Whois.whois("google.jp").expires_on
# => 2014-05-31 00:00:00 +0900

Whois.whois("google.co.jp").expires_on
# => nil

It can be obtained from "[State]" line of the result of whois.

bash$ whois -h whois.jprs.jp google.co.jp/e | grep -F '[State]'
[State]                         Connected (2014/03/31)

In this case, the expiration date is "2014/03/31".

you should not change the spec file directly

Sorry, it's my ignorance.
I'll fix my commit at a later date.

I fixed them.

The module will find the expiration date of attribute-type JP domain.

$ git clone -b support_attribute_type_jp_domain https://github.com/akagisho/whois.git

$ vi query.rb
$LOAD_PATH.push('./whois/lib')
require 'whois.rb'
puts Whois.whois("google.co.jp").expires_on

$ ruby query.rb
2014-03-31 00:00:00 +0900

@weppos weppos self-assigned this Dec 27, 2015

@weppos weppos added the parser label Dec 27, 2015

Owner

weppos commented Dec 27, 2015

Fixed in #437

@weppos weppos closed this Dec 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment