Fixed bug: JPRS, jp domain parser's empty-record bug #60

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

syonbori commented Nov 20, 2010

Hello weppos.

I found a bug about JPRS, jp domain parser in whois.jprs.jp.rb, which
does not treat lacking-record and empty-records, such as

[Created on]

[Expires on]

lines. This means the entry is empty, but current code returns the
current time, Time.parse("").

I found the miss in the regular expressions in the whois.jprs.jp.rb,
so fixed it and add some test codes and fixtures.

JPRS often answers lacking "created_on" or "expires_on".
for example, "u-tokyo.ac.jp" does not contain both.
"example.jp" is also lacking.

using my patch, those bugs are fixed.
Of course, "rake test" is passed.

fix JPRS jp domain parser's bug.
  Time.now is used if there's white-spaced entry in response. fixed it to be nil.
Owner

weppos commented Nov 20, 2010

Update CHANGELOG (closed by 653befe)

Owner

weppos commented Nov 20, 2010

Thank you very much, your patch is a perfect example of contribution.
I merged it and released Whois 1.6.3.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment