whois.markmonitor.com parser #83

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
2 participants
@semaperepelitsa
Contributor

semaperepelitsa commented Feb 23, 2011

No description provided.

+ :country_code => info[4],
+ :email => email,
+ :phone => phone,
+ :fax => fax,

This comment has been minimized.

Show comment Hide comment
@weppos

weppos Feb 23, 2011

Owner

This line causes compilation error on Ruby < 1.9 because of the comma.
Ruby 1.8.7 doesn't allow the comma when there are no other arguments in a method call. Only for Hash and Array definition.

@weppos

weppos Feb 23, 2011

Owner

This line causes compilation error on Ruby < 1.9 because of the comma.
Ruby 1.8.7 doesn't allow the comma when there are no other arguments in a method call. Only for Hash and Array definition.

@weppos

This comment has been minimized.

Show comment Hide comment
@weppos

weppos Feb 23, 2011

Owner

Very cool! I'm merging the changes.

Regarding the tests, I'm now migrating all the parser tests to a small DLS I wrote a few days ago.
See for instance d03fd7a

It should allow you to write tests with less effort.

Owner

weppos commented Feb 23, 2011

Very cool! I'm merging the changes.

Regarding the tests, I'm now migrating all the parser tests to a small DLS I wrote a few days ago.
See for instance d03fd7a

It should allow you to write tests with less effort.

@weppos

This comment has been minimized.

Show comment Hide comment
@weppos

weppos Feb 23, 2011

Owner

Merge branch whois.markmonitor.com (closed by 69461a7)

Owner

weppos commented Feb 23, 2011

Merge branch whois.markmonitor.com (closed by 69461a7)

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment