Quick fix for connection reset by final endpoint/whois referral #90

Closed
wants to merge 4 commits into from

2 participants

@jeffbozek

I was having the same issue as listed in issue #47. I can reproduce it consistently on Heroku but not locally. The fix is in adapters/base.rb. I initially had it in verisign.rb but assumed that GoDaddy can respond similarly to other tld whois requests if they are the registrar. As you suggested in the comments, one can enable it via: Whois::Client.new(:allow_incomplete_responses => true).

@weppos
Owner

I'm not sure about applying the changes in base.rb. I'm not really convinced that Errno::ECONNRESET can be univocally mapped as a ResponseIncomplete error.

Also, there's no way in the Record to know whether the response was successful or not. This can be a problem because some parsers expects a specific response format. So we need to instruct all the parsers to understand an incomplete response.

@jeffbozek
@weppos weppos closed this Apr 26, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment