whois.eu bugfixes #99

Merged
merged 6 commits into from Aug 4, 2011

2 participants

@armins

Hi weppos,

whois.eu lookups changed their syntax ('Namservers' => 'Name servers'),
i changed this inside the parser.

Furthermore i changed whois.eu test & fixture, seems to me that nameservers are returned without ip-addresses.

Armin Schreger added some commits May 31, 2011
Armin Schreger fix whois.eu Nameserver scanner regex 52b7509
Armin Schreger update comments on nameserver method 9e66a52
Armin Schreger fix whois.eu tests
expected result now without nameserver ips
a5b510b
Armin Schreger update whois.eu status_registered fixture response 2be4fbc
@armins

Some domains return hostname & ip for namesservers (e.g. servicemagic.eu), some return only hostnames (e.g. eurid.eu),
maybe my approach was wrong and both cases should be tested?

Owner

Yes, it's better to test both cases to make sure the parser won't break in case the IP is provided. I improved the tests in dd47284.

Thanks for your patch!

@weppos
Owner

Sorry for the late answer, @armins. I'm going to review this patch ASAP.

@armins

Hi @weppos,
just take a look yourself: 'whois servicemagic.eu | grep servers' - this should be easy to verify that commit 52b7509 could be pulled, you can forget the rest. If your whois-queries still respond with "Nameservers" instead of "Name Server", just drop the whole pull request :)

@weppos weppos merged commit fbe50b9 into weppos:master Aug 4, 2011
@weppos weppos added a commit that referenced this pull request Aug 4, 2011
@weppos Make sure the `whois.eu` tests include both with/without IP name serv…
…ers (references #99)
dd47284
@weppos
Owner

Merged!

Thank you very much for contributing to the Whois library.

@weppos weppos was assigned Aug 4, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment