fix(migrate2to3): new target namespace not respected in new Release

ilya-lesikov · ilya-lesikov · commit 985e24138477 · 2022-05-19T19:14:28.000+03:00
Signed-off-by: Ilya Lesikov &lt;ilya@lesikov.com&gt;
diff --git a/pkg/deploy/helm/maintenance_helper/maintenance_helper.go b/pkg/deploy/helm/maintenance_helper/maintenance_helper.go
@@ -174,6 +174,8 @@ func (helper *MaintenanceHelper) CreateHelm3ReleaseMetadataFromHelm2Release(ctx
 		return fmt.Errorf("cannot create helm 3 release %q metadata from helm 2 release %q metadata: %w", release, releaseData.Release.Name, err)
 	}
 
+	rls.Namespace = namespace
+
 	if err := helper.v3ActionConfig.Releases.Create(rls); err != nil {
 		return fmt.Errorf("error saving helm 3 release %q into storage: %w", release, err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -174,6 +174,8 @@ func (helper *MaintenanceHelper) CreateHelm3ReleaseMetadataFromHelm2Release(ctx`
`174`	`174`	`return fmt.Errorf("cannot create helm 3 release %q metadata from helm 2 release %q metadata: %w", release, releaseData.Release.Name, err)`
`175`	`175`	`}`
`176`	`176`
	`177`	`+ rls.Namespace = namespace`
	`178`	`+`
`177`	`179`	`if err := helper.v3ActionConfig.Releases.Create(rls); err != nil {`
`178`	`180`	`return fmt.Errorf("error saving helm 3 release %q into storage: %w", release, err)`
`179`	`181`	`}`