Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build,docker,buildah): add secrets support for docker and buildah #6429

Merged
merged 6 commits into from
Nov 21, 2024
Merged

feat(build,docker,buildah): add secrets support for docker and buildah #6429

merged 6 commits into from
Nov 21, 2024

Conversation

iapershin
Copy link
Collaborator

This add new feature "build secrets" for docker and buildah

@iapershin
feat(build): add secrets support for docker and buildah
b7ad301 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin
tidy
27b7347 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin
add capability
236bf90 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin iapershin assigned iapershin and unassigned iapershin Nov 20, 2024
@alexey-igrychev alexey-igrychev marked this pull request as draft November 21, 2024 10:34
@iapershin
fix tests buildah error in rootles mode
9e67c01 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin iapershin marked this pull request as ready for review November 21, 2024 11:16
@iapershin iapershin changed the title feat(build): add secrets support for docker and buildah feat(build,docker,buldah): add secrets support for docker and buildah Nov 21, 2024
@iapershin iapershin changed the title feat(build,docker,buldah): add secrets support for docker and buildah feat(build,docker,buildah): add secrets support for docker and buildah Nov 21, 2024
alexey-igrychev
alexey-igrychev requested changes Nov 21, 2024
View reviewed changes
pkg/config/image_from_dockerfile.go Outdated Show resolved Hide resolved
pkg/config/raw_image_from_dockerfile.go Outdated Show resolved Hide resolved
pkg/config/raw_image_from_dockerfile.go Outdated Show resolved Hide resolved
test/e2e/build/_fixtures/simple/state1/Dockerfile Outdated Show resolved Hide resolved
pkg/container_backend/interface.go Outdated Show resolved Hide resolved
pkg/config/raw_secrets.go Outdated Show resolved Hide resolved
pkg/config/secrets.go Outdated Show resolved Hide resolved
pkg/config/secrets.go Show resolved Hide resolved
@alexey-igrychev
Copy link
Member

alexey-igrychev commented Nov 21, 2024 •
edited
Loading

+Let's fail when a staged Dockerfile is used

@alexey-igrychev
Copy link
Member

rel #6433

@iapershin
feat(build,docker,buildah): refactor secrets config
f92c9d6 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin
refactor (config): add secrets constructor
2aea542 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@alexey-igrychev alexey-igrychev merged commit dac370b into main Nov 21, 2024
15 checks passed
@alexey-igrychev alexey-igrychev deleted the feat/build/add-secrets-support-to-docker-buildah branch November 21, 2024 16:07
@alexey-igrychev alexey-igrychev mentioned this pull request Nov 22, 2024
Closed
iapershin added a commit that referenced this pull request Dec 5, 2024
@iapershin
feat(build, docker, buildah, dockerfile): add secrets support (#6429)
3017cd0 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-igrychev alexey-igrychev alexey-igrychev approved these changes

@Fral738 Fral738 Awaiting requested review from Fral738

Assignees

@iapershin iapershin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iapershin @alexey-igrychev