Skip to content

fix(build, imageSpec): resolve env issues, labels warning, and add --skip-image-spec-stage flag #6651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 11, 2025
Merged

fix(build, imageSpec): resolve env issues, labels warning, and add --skip-image-spec-stage flag #6651

merged 20 commits into from
Mar 11, 2025

Conversation

iapershin
Copy link
Collaborator

@iapershin iapershin commented Feb 20, 2025 •
edited by alexey-igrychev
Loading

No description provided.

alexey-igrychev
alexey-igrychev requested changes Mar 3, 2025
View reviewed changes
Copy link
Member

@alexey-igrychev alexey-igrychev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config:

✗ werf config render --dev xxx                          
image: xxx
dockerfile: Dockerfile
imageSpec:
  config:
    env:
      GOROOT: "/usr/local/go"
      GOPATH: "/go"
      PATH: "${PATH}:${GOROOT}/bin:${GOPATH}/bin"

Results (crane config localhost:5001/test/test2:... | jq .config.Env):

            "Env": [
                "PATH=${PATH}:${GOROOT}/bin:${GOPATH}/bin",
                "GOROOT=/usr/local/go",
                "GOPATH=/go"
            ],

@alexey-igrychev alexey-igrychev marked this pull request as draft March 3, 2025 14:09
@alexey-igrychev alexey-igrychev force-pushed the feat/build/image-spec-enhancements branch from 6f2f8f1 to 954a2d3 Compare March 3, 2025 14:50
@iapershin iapershin marked this pull request as ready for review March 10, 2025 11:23
iapershin and others added 20 commits March 11, 2025 22:34
@iapershin @alexey-igrychev
fix(build): disable fetch base image for non-buildable stages
8a9a215 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
fix(build): fix modify labels ad envs for imagespec
d9cfb34 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
feat(build): add --skip-image-spec-stage flag
084b2c6 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
docs
ecd4893 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
docs fix
9cb6ecd 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
remove unused
f213d1b 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
fmt
eb1abb5 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
rm unused
31901ac 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
docs fix
1068b52 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@alexey-igrychev
docs(build): update
7a6d067 
Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>
@alexey-igrychev
refactor(build): add env support for --skip-image-spec-stage
4edbbb4 
Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>
@alexey-igrychev
refactor: fix typo
ab85525 
Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>
@alexey-igrychev
refactor(build): add detailed error message
9319454 
Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>
@iapershin @alexey-igrychev
fix expander, fix docs, add tests
4b19de0 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
fix
0f6a657 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
remove unused
00d7be4 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
format
0ea69a3 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
add recursion base case
1d03873 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@iapershin @alexey-igrychev
fix
07c7677 
Signed-off-by: Yaroslav Pershin <62902094+iapershin@users.noreply.github.com>
@alexey-igrychev
docs
329a4b3 
Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>
@alexey-igrychev alexey-igrychev force-pushed the feat/build/image-spec-enhancements branch from 9cfd7ec to 329a4b3 Compare March 11, 2025 23:04
@alexey-igrychev alexey-igrychev changed the title fix(build): imageSpec: fix envExpander, fix labels warning, disable fetch base image, add --skip-image-spec-stage flag fix(build, imageSpec): resolve env issues, labels warning, and add --skip-image-spec-stage flag Mar 11, 2025
@alexey-igrychev alexey-igrychev merged commit 7a8c96b into main Mar 11, 2025
26 of 27 checks passed
@alexey-igrychev alexey-igrychev deleted the feat/build/image-spec-enhancements branch March 11, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-igrychev alexey-igrychev alexey-igrychev approved these changes

@nervgh nervgh Awaiting requested review from nervgh

@Fral738 Fral738 Awaiting requested review from Fral738

Assignees
No one assigned
Labels
trigger: docs:deploy:pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iapershin @alexey-igrychev