Instantiate new ZidRecord for new entries#6
Merged
wernerd merged 1 commit intowernerd:masterfrom Nov 10, 2016
Merged
Conversation
Owner
|
Thanks for the fix. As you reported this triggered a wrong security warning, fortunately it was not a security risk :-) - just a false warning/alarm to the user. Werner |
|
@wernerd Yup, no security issue as far as we know. We thought about different ways to exploit that but didn't found any, so we reported it publicly 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, a new entry in the ZidFile copies the retained secrets and flags from the last saved ZidRecord. Then new devices could be treated like they should have a secret retained, which would raise an invalid security warning in the implementing client.
@dschuermann