New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate new ZidRecord for new entries #6

Merged
merged 1 commit into from Nov 10, 2016

Conversation

Projects
None yet
3 participants
@thefabus
Contributor

thefabus commented Nov 9, 2016

Before this commit, a new entry in the ZidFile copies the retained secrets and flags from the last saved ZidRecord. Then new devices could be treated like they should have a secret retained, which would raise an invalid security warning in the implementing client.

@dschuermann

@wernerd wernerd merged commit 1ccd889 into wernerd:master Nov 10, 2016

@wernerd

This comment has been minimized.

Owner

wernerd commented Nov 10, 2016

Thanks for the fix. As you reported this triggered a wrong security warning, fortunately it was not a security risk :-) - just a false warning/alarm to the user.

Werner

@dschuermann

This comment has been minimized.

dschuermann commented Nov 10, 2016

@wernerd Yup, no security issue as far as we know. We thought about different ways to exploit that but didn't found any, so we reported it publicly 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment