Skip to content
Browse files

maint.mk: enforce the "include <config.h> first" rule

* maint.mk (sc_require_config_h_first): New rule.
* .x-sc_require_config_h_first: New file.
  • Loading branch information...
1 parent 292d685 commit 317d2c6384839f43d8dd472dc1961fcf21ec181d Jim Meyering committed
Showing with 24 additions and 0 deletions.
  1. +9 −0 .x-sc_require_config_h_first
  2. +15 −0 maint.mk
View
9 .x-sc_require_config_h_first
@@ -0,0 +1,9 @@
+^lib/buffer-lcm\.c$
+^src/false\.c$
+^src/lbracket\.c$
+^src/ls-dir\.c$
+^src/ls-ls\.c$
+^src/ls-vdir\.c$
+^src/tac-pipe\.c$
+^src/uname-arch\.c$
+^src/uname-uname\.c$
View
15 maint.mk
@@ -191,6 +191,21 @@ sc_require_config_h:
else :; \
fi
+# You must include <config.h> before including any other header file.
+sc_require_config_h_first:
+ @if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then \
+ fail=0; \
+ for i in $$($(VC_LIST_EXCEPT) | grep '\.c$$'); do \
+ grep '^# *include\>' $$i | sed 1q \
+ | grep '^# *include <config\.h>' > /dev/null \
+ || { echo $$i; fail=1; }; \
+ done; \
+ test $$fail = 1 && \
+ { echo '$(ME): the above files include some other header' \
+ 'before <config.h>' 1>&2; exit 1; } || :; \
+ else :; \
+ fi
+
# To use this "command" macro, you must first define two shell variables:
# h: the header, enclosed in <> or ""
# re: a regular expression that matches IFF something provided by $h is used.

0 comments on commit 317d2c6

Please sign in to comment.
Something went wrong with that request. Please try again.