Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Make sure git-review is able to detect git errors again.

Also speeds up the check for the changes remote.
  • Loading branch information...
commit 25a3942b20e58856a52ce4835189eeb494e10808 1 parent 07b30b5
Brian Donovan authored
Showing with 4 additions and 3 deletions.
  1. +4 −3 bin/git-review
View
7 bin/git-review
@@ -38,7 +38,8 @@ git() {
fi
if [ "$run" = true ]; then
- eval "git_output=\$($GIT $@ 2>&1 | tee /dev/tty)"
+ $GIT $@ 2>&1 | tee /dev/tty > /tmp/git_output
+ return ${PIPESTATUS[0]}
fi
}
@@ -193,7 +194,7 @@ pushReview() {
git push $change_args ||
die "Could not push your changes for review. Perhaps you need to update first?"
- git_push_output="$git_output"
+ git_push_output=$(cat /tmp/git_output)
if [ "$CURRENT" = "$TRACK" ]; then
git reset --hard $REMOTE/$TRACK ||
@@ -220,7 +221,7 @@ startReview() {
abort_on_bad_repo_state
getBranchInfo
- $GIT remote show changes 2>/dev/null 1>&2 ||
+ $GIT remote show -n changes 2>/dev/null 1>&2 ||
die "In order to use $this to start a review, you need a 'changes' remote. Please add it before trying again."
# pick up the latest patch for the changeset we're reviewing
Please sign in to comment.
Something went wrong with that request. Please try again.