Permalink
Switch branches/tags
Nothing to show
Commits on Jul 16, 2009
  1. Revert "Really fix git-review so it works in sh on linux."

    This reverts commit ca4f322, as we're really running bash now.
    Brian Donovan committed Jul 16, 2009
  2. Fix the escaping vs. bash problem.

    Apparently in Ubuntu's /bin/sh, `echo' refers to /bin/echo, which does not
    support the -e flag (interprets backslash-escaped characters). In /bin/bash,
    however, `echo' refers to the builtin command, which does support the -e flag.
    
    So what it boils down to is some difference in how Mac OS X's bash and Ubuntu's
    bash handle escaping, but the fact that I can't nail down exactly what that is
    probably means we'll have to revisit this in the future.
    Brian Donovan committed Jul 16, 2009
  3. Really fix git-review so it works in sh on linux.

    sh doesn't support ${foo:n} syntax for substring extraction, so I had to resort to shelling out to cut. Eww, but it works.
    
    So, what was the reason for not using bash?
    bgreenlee committed Jul 16, 2009
  4. Fix hack so it works on deploy

    bgreenlee committed Jul 16, 2009
Commits on Jul 13, 2009
  1. Revert the sh -> bash change, as it seems broken on more machines tha…

    …n before.
    
    This reverts commits b7a9b8a & ce52a65.
    Brian Donovan committed Jul 10, 2009
Commits on Jul 10, 2009
Commits on Jul 2, 2009
  1. Add diff function to git-review to allow easy viewing of diffs betwee…

    …n changeset patches.
    
    git-review diff <changeset>
      Displays the diff between the last two patches in the given changeset
    
    git-review diff <changeset> <patch number 1> <patch number 2>
      Displays the diff between <patch number 1> and <patch number 2> of the changeset
    bgreenlee committed Jul 2, 2009
Commits on Jun 19, 2009
  1. Just switching them all to bash.

    I mean, really. If we don't have bash, we have bigger issues than these scripts not working.
    indirect committed Jun 19, 2009
  2. Say what shell we mean

    indirect committed Jun 19, 2009
Commits on Jun 17, 2009
Commits on Jun 16, 2009
  1. Fix `git-review push N'.

    Brian Donovan committed Jun 16, 2009
Commits on Jun 15, 2009
  1. Make git-review handle pulling review patches, too.

    The 'push' subcommand is required to emulate the old functionality, so this
    
        git review
    
    becomes
    
        git review push
    
    To pull in another review just make sure you have the right 'changes' remote and use
    the 'start' subcommand:
    
        git review start 45
    
    Once you're done reviewing it, just use the 'reset' subcommand:
    
        git review reset
    Brian Donovan committed Jun 15, 2009
Commits on Jun 12, 2009
  1. Fix git-review without a change number.

    Apparently when given no arguments ${!#} is $0, the binary path.
    Brian Donovan committed Jun 12, 2009
Commits on Jun 11, 2009
  1. Be a bit less verbose about what's going on.

    Brian Donovan committed Jun 11, 2009
Commits on Jun 10, 2009
  1. Add git-review to help enforce review best practices with tools like …

    …Gerrit.
    Brian Donovan committed Jun 10, 2009
Commits on May 19, 2009
  1. Whoops, other way around.

    Brian Donovan committed May 19, 2009
  2. Don't act like things actually happened if we're not really doing any…

    …thing.
    Brian Donovan committed May 19, 2009
Commits on May 14, 2009
  1. Adds colors, better messaging, and removes grep tricks.

    Brian Donovan committed May 14, 2009
Commits on May 11, 2009
  1. Make sure to negate the branch tree SHAs, and give list_from_string '…

    …raw' formatted commit logs.
    Brian Donovan committed May 11, 2009
  2. Handle creating/deleting branches.

    Brian Donovan committed May 11, 2009
Commits on Apr 27, 2009
Commits on Apr 22, 2009
  1. Some versions of git apparently don't put git-sh-setup in the PATH, s…

    …o don't use it.
    Brian Donovan committed Apr 22, 2009
  2. Put in a whole bunch of error messages.

    Brian Donovan committed Apr 22, 2009
  3. Include the stash commands if the '-e' flag is given.

    Brian Donovan committed Apr 22, 2009
  4. Automatically stash local changes when hacking.

    This is good when all goes well, but probably not so good when it doesn't. Need more error detection & recovery.
    Brian Donovan committed Apr 22, 2009
Commits on Mar 24, 2009
  1. Check for being on the target branch already.

    Brian Donovan committed Mar 24, 2009
Commits on Mar 18, 2009
  1. Use actual git commands to retrieve this.

    Deconstructing a formatted message is not a good idea.
    Brian Donovan committed Mar 18, 2009
Commits on Feb 4, 2009
  1. Account for tracking branches when hacking/shipping.

    Brian Donovan committed Feb 4, 2009
Commits on Jan 22, 2009
Commits on Nov 24, 2008
  1. Follow as many levels of symlinks as there are.

    Brian Donovan committed Nov 24, 2008
Commits on Nov 18, 2008
Commits on Nov 17, 2008