Skip to content

/ snap-sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btrfs send takes options before arguments #34

Merged
merged 1 commit into from May 29, 2017
Merged

btrfs send takes options before arguments #34

merged 1 commit into from May 29, 2017

Conversation

@kalbasit
Copy link
Contributor

kalbasit commented May 29, 2017 •
edited

btrfs-progs 4.11 includes this patch0 which has updated the option
parser which has enforced the order in which arguments and options
appear in. See this email for context1

fixes #32

Thank you Tsutomu Itoh for pointing this out.
@kalbasit
btrfs send takes options before arguments
Unverified
This user has not uploaded their public key yet.
GPG key ID: 55653945C8DD18A2 Learn about signing commits
effa00c 
btrfs-progs 4.11 includes this patch[0] which has updated the option
parser which has enforced the order in which arguments and options
appear in. See this email for context[1]

[0]: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git/commit/?id=010ceab56e067b87ea282fde6ff792c1ceefd7dc
[1]: https://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg62226.html
@kalbasit
Copy link
Contributor Author

kalbasit commented May 29, 2017

@NicoHood does this PR fixes it for you? @wesbarnett please wait until the fix is confirmed before merging.
@kalbasit
Copy link
Contributor Author

kalbasit commented May 29, 2017

I confirm it's working for me, @wesbarnett please merge and release, thank you.

sudo snap-sync -c @root -u e6437994-dced-4441-a3af-344694bb7f37

You selected the disk with UUID e6437994-dced-4441-a3af-344694bb7f37.
The disk is mounted at /mnt/Madea.

Initial configuration...

Creating new snapshot for @root...
Will backup //.snapshots/869/snapshot to /mnt/Madea/snap-sync/cratos/@root/869//snapshot
Continue with backup [Y/n]?

Performing backups...

Sending incremental snapshot for @root...
At subvol //.snapshots/869/snapshot
At snapshot snapshot
Deleting old snapshot for @root...
Tagging new snapshot as latest backup for @root...

Done!
@wesbarnett wesbarnett merged commit c040bc0 into wesbarnett:master May 29, 2017
@wesbarnett
Copy link
Owner

wesbarnett commented May 29, 2017

Thanks for all the work!
@kalbasit kalbasit deleted the kalbasit:fix_crash_btrfs_4_11 branch May 29, 2017
@NicoHood
Copy link
Contributor

NicoHood commented May 29, 2017

I could not test yet, but thanks a lot for you help.
@wesbarnett Maybe worth a new tag. You also changed a few other things since the last release.
@NicoHood
Copy link
Contributor

NicoHood commented May 29, 2017

Okay I tested the new version and it works fine. However I got the config in use error #21 again.
Snap-sync does not abort and continues which I think is okay in this situation. I hope this does not happen for other unexpected errors.
@kalbasit
Copy link
Contributor Author

kalbasit commented May 29, 2017

@NicoHood I added a set -e in #36, that will force it to stop on the first error.
@wesbarnett
Copy link
Owner

wesbarnett commented May 30, 2017

@NicoHood Fixed with #38.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

ERROR: unable to resolve -c
3 participants
@kalbasit @wesbarnett @NicoHood
You can’t perform that action at this time.