Added Twitter Card - #281
Merged
Merged
Conversation
Collaborator
|
@jreyes88 I believe we can use a See https://www.gatsbyjs.org/docs/static-folder/#adding-assets-outside-of-the-module-system I'm not sure I'm a fan of the last line of tags being cropped in the image you posted. |
Owner
|
This is awesome! Could you do one thing and swap out the image with this one? |
Contributor
Author
|
I think I got the right image in there. And good call @HugoDF on the |
Collaborator
|
Better yet, use this image instead!
In the time I took to edit and post this, you'd already uploaded the other image! Just suggesting a cleaner alternative here <3 |
Contributor
Author
|
Ack, not sure if I should have closed it. Sorry, I'm new to this. Reopening now. |
Owner
|
thanks a ton! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #274
This is my first pull request on someone else's repo so I hope I'm doing this correctly.
I saw Wes' ticket about adding a Twitter card, so I went ahead and did that. The only thing missing is the image for the Twitter card, which I referenced as a file titled "twitter-card.png". I placed this file in
/public, but that directory is gitignored. It was just a screenshot of the top of the page, but this file could be anything.I figured
/publicwould be a good spot for it since we don't actually need to do any work with it, Twitter just needs a preview image. Attaching it here.Happy to remove the image line if it's too much trouble.