Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draw.io Integration #1685

Merged
merged 9 commits into from Mar 9, 2020
Merged

Conversation

@kaishuu0123
Copy link
Contributor

kaishuu0123 commented Mar 4, 2020

Demo (Light ver.)

20200304_growi_drawio_integration

Demo (Full ver. Youtube)

Features

  • Add draw.io diagram
  • Edit draw.io diagram
    • CASE 1: Editing or Add conditional branching depending on the cursor position in the Editor.
    • CASE 2: Click edit button in Page View.
  • Preview draw.io diagram

Task

The long string added to the editor represents Base64 encoded draw.io data.
However, this is confusing to the user, so the collapsible feature will be implemented in another PR.

@kaishuu0123 kaishuu0123 changed the title Add draw.io Integeration Add draw.io Integration Mar 4, 2020
src/client/styles/scss/_page.scss Outdated Show resolved Hide resolved
src/client/styles/scss/_page.scss Outdated Show resolved Hide resolved
@kaishuu0123

This comment has been minimized.

Copy link
Contributor Author

kaishuu0123 commented Mar 9, 2020

@yuki-takei Feedback を元に修正が完了しました。(念のためメンション)

@yuki-takei yuki-takei merged commit 3234fd6 into weseek:master Mar 9, 2020
@kaishuu0123 kaishuu0123 deleted the kaishuu0123:feat/drawio-integration branch Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.