Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add markdown-it-blockdiag (like PlantUML) #458

Merged
merged 2 commits into from Jun 8, 2018
Merged

Conversation

@kaishuu0123
Copy link
Contributor

kaishuu0123 commented Jun 7, 2018

I implemented live preview of blockdiag.
If you like this please merge.

Demo

markdown-it-blockdiag-demo

refs

@yuki-takei

This comment has been minimized.

Copy link
Member

yuki-takei commented Jun 7, 2018

@kaishuu0123 Great! Thank you for your contribution.

I have one point to propose to change.

I think fence blocks with 3 back quotes shold be used only to show pre elements on GROWI.
So I would like you to consider replace marker from back quote to something else.

For instance, markdown-it-plantuml has openMarker/closeMarker options. But the implementation of it may be too complex a little bit.

It may be nice to use markdown-it-fence.

@kaishuu0123

This comment has been minimized.

Copy link
Contributor Author

kaishuu0123 commented Jun 8, 2018

Currently markdown-it-blockdiag changes the behavior of *diag type by string after 3 back quote.

Are there any good ideas for Maker? (@startblockdiag, @startseqdiag etc ...)

I will think about it, too.
Please wait for a little while longer.

@kaishuu0123

This comment has been minimized.

Copy link
Contributor Author

kaishuu0123 commented Jun 8, 2018

@yuki-takei

markdown-it-blockdiag has been modified to use markdown-it-fence, and add marker option.
explicitly set the marker to ```.

@yuki-takei yuki-takei merged commit f46ec81 into weseek:master Jun 8, 2018
3 checks passed
3 checks passed
wercker/build-dev Wercker pipeline passed
Details
wercker/build-prod Wercker pipeline passed
Details
wercker/test Wercker pipeline passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.