New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify filename #122

Closed
rudin opened this Issue Feb 20, 2018 · 3 comments

Comments

3 participants
@rudin

rudin commented Feb 20, 2018

I've noticed that when downloading an image it always has a default filename 'image.jpg'.
It would be great if you could add a parameter 'filename' to specify the name returned in the Content-Disposition header i.e. Content-Disposition: filename="filename.jpg" and when not specified use the filename of the file that has been loaded.

@andrieslouw

This comment has been minimized.

Member

andrieslouw commented Feb 20, 2018

There are some concerns to address, but we will consider introducing this option. Only way I see is by introducing a limit on the character set and the length of the filename provided. The difficulty is explained here: http://en.wikipedia.org/wiki/Filename

@andrieslouw andrieslouw self-assigned this Feb 20, 2018

@rudin

This comment has been minimized.

rudin commented Mar 6, 2018

I can also imagine a limit would be required and even some normalisation (limiting/converting the character set).

@kleisauke

This comment has been minimized.

Member

kleisauke commented Mar 18, 2018

Implemented, see https://images.weserv.nl/#filename. Please help by testing it.

Let me know if you run into any problems, thanks!

@kleisauke kleisauke closed this Apr 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment