Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#_ is deprecated #152

Open
Toddses opened this Issue Apr 17, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@Toddses
Copy link
Collaborator

Toddses commented Apr 17, 2015

Get this warning when running YeoPress with the latest version of yeoman-generator (0.19.1)

(!) #_ is deprecated. Require your own version of Lodash or underscore.string

@Toddses Toddses added bug and removed bug labels Apr 17, 2015

@wesleytodd

This comment has been minimized.

Copy link
Owner

wesleytodd commented Apr 17, 2015

yeoman/generator#766

Looks like our new release will need this fix as well.

@wesleytodd

This comment has been minimized.

Copy link
Owner

wesleytodd commented Apr 18, 2015

This is actually a much bigger problem than I thought. The fs refactor is causing internal wordpress files to be parsed as templates, specifically this one: https://core.trac.wordpress.org/browser/tags/4.1.1/src/wp-includes/class-wp-customize-widgets.php#L708

So this is actually mangling wp functionality.

I dont have time to work on this right now, but if you want to, all we need to do is make that one call NOT do template parsing.

@wesleytodd

This comment has been minimized.

Copy link
Owner

wesleytodd commented Apr 18, 2015

and fwiw, i pushed an error log and a beta tag in package.json so if we get this fixed we can publish a beta with the fixes.

@wesleytodd wesleytodd added the bug label Apr 19, 2015

This was referenced Apr 19, 2015

@Vivekbhusal

This comment has been minimized.

Copy link

Vivekbhusal commented Jul 8, 2015

is there any update on for this issue? i am trying to generate wordpress-plugin using wp-make. Is there any work around or patches?

@Toddses

This comment has been minimized.

Copy link
Collaborator Author

Toddses commented Jul 8, 2015

Not really atm. Time has been an issue for me lately, as I'm sure for Wes as well. If someone can issue a valid pull request I am sure we will pull it in.

That said I have still been using YeoPress with this deprecation warning and have had no issues myself.

@wesleytodd

This comment has been minimized.

Copy link
Owner

wesleytodd commented Jul 8, 2015

^^ what he said :)

Also I am not sure where wp-make comes in here, are you trying to switch to yeopress? If so this issue shouldn't actually break anything, we just need to fix it before it is actually removed from yeoman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.