From 967a2ac0c51cd369f8df7a8e30abe790babc64c1 Mon Sep 17 00:00:00 2001 From: Alexander van Gessel Date: Fri, 21 Nov 2014 17:38:00 +0100 Subject: [PATCH] Improve dynamic cast null-check Found by coverity --- src/gui/dialogs/debug_clock.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gui/dialogs/debug_clock.cpp b/src/gui/dialogs/debug_clock.cpp index c33c1f3f8e7d..ef2913909953 100644 --- a/src/gui/dialogs/debug_clock.cpp +++ b/src/gui/dialogs/debug_clock.cpp @@ -86,16 +86,16 @@ void tdebug_clock::pre_show(CVideo& /*video*/, twindow& window) &window, "second_percentage", false, false); hour_ = find_widget(&window, "hour", false, false); - if(dynamic_cast(hour_)) { //Note that the standard specifies that a dynamic cast of a null pointer is null - dynamic_cast(hour_)->set_active(false); + if(tcontrol *hour = dynamic_cast(hour_)) { //Note that the standard specifies that a dynamic cast of a null pointer is null + hour->set_active(false); } minute_ = find_widget(&window, "minute", false, false); - if(dynamic_cast(minute_)) { - dynamic_cast(minute_)->set_active(false); + if(tcontrol *minute = dynamic_cast(minute_)) { + minute->set_active(false); } second_ = find_widget(&window, "second", false, false); - if(dynamic_cast(second_)) { - dynamic_cast(second_)->set_active(false); + if(tcontrol *second = dynamic_cast(second_)) { + second->set_active(false); } pane_ = find_widget(&window, "pane", false, false);