From b7d262b3c5f664fbae2e2cc0a700097e8976c61e Mon Sep 17 00:00:00 2001 From: Charles Dang Date: Mon, 20 Feb 2017 13:56:46 +1100 Subject: [PATCH] MP Options Helper: remove options from both type of games when updating (bug #25526) --- src/gui/dialogs/multiplayer/mp_options_helper.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gui/dialogs/multiplayer/mp_options_helper.cpp b/src/gui/dialogs/multiplayer/mp_options_helper.cpp index 3e61b3304608..2df434a818ac 100644 --- a/src/gui/dialogs/multiplayer/mp_options_helper.cpp +++ b/src/gui/dialogs/multiplayer/mp_options_helper.cpp @@ -64,7 +64,10 @@ void mp_options_helper::update_game_options() { const std::string type = create_engine_.current_level_type() == ng::level::TYPE::CAMPAIGN ? "campaign" : "multiplayer"; - int pos = remove_nodes_for_type(type); + // For game options, we check for both types and remove them. This is to prevent options from a game + // of one type remaining visible when selecting a game of another type. + int pos = remove_nodes_for_type("campaign"); + pos = remove_nodes_for_type("multiplayer"); display_custom_options(type, pos, create_engine_.current_level().data());