From ba4202caf8b916692dd254f1eddb54bff74153f6 Mon Sep 17 00:00:00 2001 From: mattsc Date: Sun, 16 Dec 2018 16:17:15 -0800 Subject: [PATCH] AI code: remove more outdated TODOs Some more comments and explanations in Issue #3695. --- src/ai/actions.cpp | 6 +----- src/ai/contexts.cpp | 1 - src/ai/manager.hpp | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/ai/actions.cpp b/src/ai/actions.cpp index 509fcb07ad47..2c66bb1467ca 100644 --- a/src/ai/actions.cpp +++ b/src/ai/actions.cpp @@ -417,7 +417,6 @@ void move_result::do_check_after() set_error(E_FAILED_TELEPORT); return; } - ///@todo 1.9 add 'new units spotted' failure mode if (!unreach_is_ok_ && unit_location_!=to_) { set_error(E_NOT_REACHED_DESTINATION); @@ -471,7 +470,7 @@ void move_result::do_execute() std::size_t num_steps = ::actions::move_unit_and_record( /*std::vector steps*/ route_->steps, /*::actions::undo_list* undo_stack*/ nullptr, - /*bool continue_move*/ true, ///@todo 1.9 set to false after implementing interrupt awareness + /*bool continue_move*/ true, /*bool show_move*/ !preferences::skip_ai_moves(), /*bool* interrupted*/ nullptr, /*::actions::move_unit_spectator* move_spectator*/ &move_spectator); @@ -799,9 +798,6 @@ void recruit_result::do_execute() } synced_context::run_in_synced_context_if_not_already("recruit", replay_helper::get_recruit(u->id(), recruit_location_, recruit_from_), false, !preferences::skip_ai_moves()); - //TODO: should we do something to pass use_undo = false in replays and ai moves ? - //::actions::recruit_unit(*u, get_side(), recruit_location_, recruit_from_, - // !preferences::skip_ai_moves(), false); set_gamestate_changed(); try { diff --git a/src/ai/contexts.cpp b/src/ai/contexts.cpp index 13f9a9db532f..7df9e9ffeeec 100644 --- a/src/ai/contexts.cpp +++ b/src/ai/contexts.cpp @@ -1163,7 +1163,6 @@ void readonly_context_impl::recalculate_move_maps() const ++it; } } - ///@todo: shall possible moves be modified as well ? } } move_maps_valid_ = true; diff --git a/src/ai/manager.hpp b/src/ai/manager.hpp index 0730a7961c77..fc1e0e2d5ad7 100644 --- a/src/ai/manager.hpp +++ b/src/ai/manager.hpp @@ -48,7 +48,6 @@ namespace ai /** * Base class that holds the AI and current AI parameters. * It is an implementation detail. - * @todo 1.9 move it out of public view */ class holder{ public: