From c5e95d3b245411dfa5a8d722e0bd61f9d9635db5 Mon Sep 17 00:00:00 2001
From: Charles Dang <exodia339@gmail.com>
Date: Sun, 11 Feb 2018 14:23:27 +1100
Subject: [PATCH] MP Lobby: avoid unnecessary cache rebuild if no required
 addons were installed

I was unconditionally reloading the cache even if there were a reason ad_hoc_addon_fetch_session
failed. The cache will no longer be reloaded if said function didn't actually install anything.

Fixes #2477.
---
 src/gui/dialogs/multiplayer/lobby.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/gui/dialogs/multiplayer/lobby.cpp b/src/gui/dialogs/multiplayer/lobby.cpp
index e23fbb6d4f77..acfb5095ca90 100644
--- a/src/gui/dialogs/multiplayer/lobby.cpp
+++ b/src/gui/dialogs/multiplayer/lobby.cpp
@@ -262,9 +262,7 @@ bool handle_addon_requirements_gui(const std::vector<mp::game_info::required_add
 
 		if(gui2::show_message(e_title, err_msg, message::yes_no_buttons, true) == gui2::window::OK) {
 			// Begin download session
-			ad_hoc_addon_fetch_session(needs_download);
-
-			return true;
+			return ad_hoc_addon_fetch_session(needs_download);
 		}
 	}