From e7c0a69420f59abbaf914db2a06b610b55726d4b Mon Sep 17 00:00:00 2001 From: Iris Morelle Date: Tue, 17 Apr 2018 22:08:37 -0300 Subject: [PATCH] Fix segfault when trying to log into the MP server with an empty password Probable regression introduced in commit 02ab29d2f19800d28fa10476c48261be1083ad2c (1.13.14). (cherry-picked from commit fc88cdff3b04a77a6de6d3911821cf4e1c7612d6) --- src/preferences/credentials.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/preferences/credentials.cpp b/src/preferences/credentials.cpp index c8024830b6c9..8bfbcbf43e88 100644 --- a/src/preferences/credentials.cpp +++ b/src/preferences/credentials.cpp @@ -278,7 +278,7 @@ secure_buffer encrypt(const secure_buffer& text, const secure_buffer& key) secure_buffer decrypt(const secure_buffer& text, const secure_buffer& key) { auto buf = rc4_crypt(text, key); - while(buf.back() == 0) { + while(!buf.empty() && buf.back() == 0) { buf.pop_back(); } return buf;