Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain lobby message history during games (GNA #15650) #1194

Closed
wesnoth-bugs opened this issue May 8, 2017 · 11 comments

Comments

Projects
None yet
4 participants
@wesnoth-bugs
Copy link

commented May 8, 2017

Original submission by mystic_x on 2010-03-18

mp lobby room chat log, and all whisper room logs get erased whenever the user leaves the main lobby (so enters a game as observer/player, a game lobby or create game dialog).

(Reproduced on any)
Release: 1.7.15
Priority: 3 - Low
Severity: 2 - Minor

@wesnoth-bugs

This comment has been minimized.

Copy link
Author

commented May 8, 2017

Modified on 2010-03-25

ilor changed priority: 5 - Normal -> 3 - Low

ilor wrote:

While this is a regression from the old lobby, the "old" behavior wasn't perfect anyway so this will probably wait till the more major lobby issues are sorted out.

ilor changed status: None -> Postponed

@wesnoth-bugs

This comment has been minimized.

Copy link
Author

commented May 8, 2017

Modified on 2010-04-05

ivanovic changed item group: User Interface -> Multiplayer Lobby

@wesnoth-bugs

This comment has been minimized.

Copy link
Author

commented May 8, 2017

Modified on 2010-04-08

ilor changed severity: 3 - Normal -> 2 - Minor

@wesnoth-bugs

This comment has been minimized.

Copy link
Author

commented May 8, 2017

Modified on 2012-01-29

shadowmaster changed status: Postponed -> None

@wesnoth-bugs

This comment has been minimized.

Copy link
Author

commented May 8, 2017

Modified on 2012-09-03

shadowmaster wrote:

Deassigning bugs from inactive developers.

@wesnoth-bugs

This comment has been minimized.

Copy link
Author

commented May 8, 2017

Modified on 2014-06-19

laundry wrote:

I will work on this. Hopefully I can fix it.

@wesnoth-bugs

This comment has been minimized.

Copy link
Author

commented May 8, 2017

Modified on 2014-06-19

laundry wrote:

As I understand the "bug" is that when you leave the multiplayer lobby by :Entering a game, create a game, or going back to the title screen the lobby chat becomes erased. I do not think this is a bug because this is supposed to be how it works.

As you can see in the pictures I attached I said "Hi I am Austin DeLauney". I then quit and go to the title screen, then re-enter the multiplayer lobby and my chat is gone. I believe that is how it is supposed to work for the main lobby.

The Whisper chats are getting erased from transitions, which shouldn't happen (As those are private and should be kept) I still haven't investigated Whisper chats but to my understanding that is what they're supposed to do.

(file #21095, file #21096)

laundry added attachment: Multiplayer Lobby Chat.png

multiplayer lobby chat

laundry added attachment: Multiplayer Lobby Chat after.png

multiplayer lobby chat after

@wesnoth-bugs

This comment has been minimized.

Copy link
Author

commented May 8, 2017

Modified on 2014-06-19

laundry wrote:

NOTE This is not a bug, this is just how the chat works. It looks like if we want to fix this we'd have to revamp the whole chat system NOTE

@wesnoth-bugs

This comment has been minimized.

Copy link
Author

commented May 8, 2017

Modified on 2014-06-20

soliton changed OS: . -> any

soliton changed category: Bug -> Feature Request

soliton changed title: lobby messages keep getting deleted -> retain lobby message history during games

@ProditorMagnus

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2018

Works for 1.12, broken for 1.13.

@jyrkive

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

Implemented in commit 8a00276.

@jyrkive jyrkive closed this Apr 17, 2018

jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018

@jostephd jostephd referenced this issue Oct 14, 2018

Closed

Forward-port 1.14 to development #3614

959 of 959 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.