Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing and sheathing animations lack ellipses (GNA #24314) #1527

Open
wesnoth-bugs opened this issue May 8, 2017 · 4 comments

Comments

@wesnoth-bugs
Copy link

@wesnoth-bugs wesnoth-bugs commented May 8, 2017

Original submission by zookeeper on 2016-01-15

Unit ellipses are drawn during all other combat animations, but not during draw_weapon and sheath_weapon animations.

Sky Drake, Hurricane Drake and Merman Hunter are easy core testcases.

(Reproduced on win)
Release: 1.13.2+dev
Priority: 5 - Normal
Severity: 2 - Minor

@wesnoth-bugs

This comment has been minimized.

Copy link
Author

@wesnoth-bugs wesnoth-bugs commented May 8, 2017

Modified on 2016-03-07

zookeeper wrote:

Same also applies to healing, healed and poisoned animations. While not combat animations, I see no reason why ellipses should turn off during them.

@Wedge009 Wedge009 added Confirmed and removed Windows labels May 9, 2017
@Wedge009

This comment has been minimized.

Copy link
Member

@Wedge009 Wedge009 commented Sep 11, 2019

Still seems to be present in 1.14.7. I noticed ellipses are not drawn during unit movements - I assume that's intentional and expected behaviour, it's only a problem with combat animations.

jostephd added a commit that referenced this issue Sep 16, 2019
@jostephd

This comment has been minimized.

Copy link
Member

@jostephd jostephd commented Sep 16, 2019

Unit ellipses are drawn during all other combat animations, but not during draw_weapon and sheath_weapon animations.

Fixed: d26c2a2

Same also applies to healing, healed and poisoned animations. While not combat animations, I see no reason why ellipses should turn off during them.

@ln-zookeeper Ellipses and health/XP bars are enabled and disabled together. The animations do look better without bars IMO, so maybe for this case we could disable the bars but keep the ellipses.

for (unit *h : healers) {
h->set_facing(h->get_location().get_relative_dir(healed_loc));
animator.add_animation(h, "healing", h->get_location(),
healed_loc, healing);
}
if (healing < 0) {
animator.add_animation(&healed, "poisoned", healed_loc,
map_location::null_location(), -healing, false,
number_and_text(-healing, extra_text),
{255,0,0});
} else if ( healing > 0 ) {
animator.add_animation(&healed, "healed", healed_loc,
map_location::null_location(), healing, false,
number_and_text(healing, extra_text),
{0,255,0});
} else {
animator.add_animation(&healed, "healed", healed_loc,
map_location::null_location(), 0, false,
extra_text, {0,255,0});
}

jostephd added a commit that referenced this issue Sep 16, 2019
jostephd added a commit that referenced this issue Sep 30, 2019
@Wedge009

This comment has been minimized.

Copy link
Member

@Wedge009 Wedge009 commented Oct 4, 2019

What's still outstanding here? I see ellipses are active now for drawing/sheathing animations. If it's a question about healing, etc, I wonder if that should be a separate issue? I just did a quick check and the ellipses and HP/XP bars are removed for healing for all units, not just the drakes/mermen mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.