New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages, which have their portrait on the right, are not centered #1938

Closed
sevu opened this Issue Sep 3, 2017 · 8 comments

Comments

Projects
None yet
5 participants
@sevu
Member

sevu commented Sep 3, 2017

shaman
While most other messages have their message centered.

@sevu sevu added Bug UI labels Sep 3, 2017

@CelticMinstrel

This comment has been minimized.

Show comment
Hide comment
@CelticMinstrel

CelticMinstrel Sep 3, 2017

Member

I'm not sure this should be considered a bug...

Member

CelticMinstrel commented Sep 3, 2017

I'm not sure this should be considered a bug...

@sevu

This comment has been minimized.

Show comment
Hide comment
@sevu

sevu Sep 3, 2017

Member

It just doesn't look good if all other messages are centered, and the shamans one in between not.

Member

sevu commented Sep 3, 2017

It just doesn't look good if all other messages are centered, and the shamans one in between not.

@CelticMinstrel

This comment has been minimized.

Show comment
Hide comment
@CelticMinstrel

CelticMinstrel Sep 3, 2017

Member

I'm not even sure what you mean by centred. Aren't all messages left-aligned?

Member

CelticMinstrel commented Sep 3, 2017

I'm not even sure what you mean by centred. Aren't all messages left-aligned?

@doofus-01

This comment has been minimized.

Show comment
Hide comment
@doofus-01

doofus-01 Sep 4, 2017

Member

I see what sevu is saying, although CelticMinstrel may be correct, strictly speaking.

  1. Most portraits have some dead-space/padding; you don't see the left-justified text huddled up next to the portrait subject's face. But there is (apparently) no such intrinsic padding for the left edge of the screen.
  2. The word-wrap or newline also does not extend to the right side of the visual bounding box, for some common resolutions at least. When the portrait is on the right, the newline coordinate is shifted to the left, so this extra right-hand padding is added to whatever intrinsic padding of the portrait (and that the left screen edge does not have).

Net effect is that the portrait-left/portrait-right dialogues aren't at all symmetric, beyond what can be attributed to the left-justified text.

Member

doofus-01 commented Sep 4, 2017

I see what sevu is saying, although CelticMinstrel may be correct, strictly speaking.

  1. Most portraits have some dead-space/padding; you don't see the left-justified text huddled up next to the portrait subject's face. But there is (apparently) no such intrinsic padding for the left edge of the screen.
  2. The word-wrap or newline also does not extend to the right side of the visual bounding box, for some common resolutions at least. When the portrait is on the right, the newline coordinate is shifted to the left, so this extra right-hand padding is added to whatever intrinsic padding of the portrait (and that the left screen edge does not have).

Net effect is that the portrait-left/portrait-right dialogues aren't at all symmetric, beyond what can be attributed to the left-justified text.

@Vultraz

This comment has been minimized.

Show comment
Hide comment
@Vultraz

Vultraz Sep 4, 2017

Member

I honestly think this provides nice visual variation for portraits on the right.

Member

Vultraz commented Sep 4, 2017

I honestly think this provides nice visual variation for portraits on the right.

@sevu

This comment has been minimized.

Show comment
Hide comment
@sevu

sevu Sep 4, 2017

Member

I see why you think so. On the resolution of the example above (1440x752), the messages with the image on the left look like being the opposite of the one shown above.

But if you have the window on 1920x1080 it is different, because then the text from the messages with the image on the left looks clearly centred, while messages where the image is on the right have the text still on the very left.
(the text itself is left-aligned , as pointed out earlier)
archer

shaman2

Member

sevu commented Sep 4, 2017

I see why you think so. On the resolution of the example above (1440x752), the messages with the image on the left look like being the opposite of the one shown above.

But if you have the window on 1920x1080 it is different, because then the text from the messages with the image on the left looks clearly centred, while messages where the image is on the right have the text still on the very left.
(the text itself is left-aligned , as pointed out earlier)
archer

shaman2

@CelticMinstrel CelticMinstrel added Enhancement and removed Bug labels Sep 4, 2017

@CelticMinstrel

This comment has been minimized.

Show comment
Hide comment
@CelticMinstrel

CelticMinstrel Sep 4, 2017

Member

We can certainly add some padding on the left for right-portrait messages.

Member

CelticMinstrel commented Sep 4, 2017

We can certainly add some padding on the left for right-portrait messages.

jostephd added a commit to jostephd/wesnoth that referenced this issue Sep 7, 2018

WML [message]: Add left padding when the portrait is shown on the right.
The text is now shown at exactly the same place regardless of which side
the portrait is on.

Fixes wesnoth#1938.
@jostephd

This comment has been minimized.

Show comment
Hide comment
@jostephd
Member

jostephd commented Sep 7, 2018

GregoryLundberg added a commit that referenced this issue Sep 14, 2018

WML [message]: Add left padding when the portrait is shown on the right.
The text is now shown at exactly the same place regardless of which side
the portrait is on.

Fixes #1938.

jostephd added a commit to jostephd/wesnoth that referenced this issue Sep 14, 2018

WML [message]: Add left padding when the portrait is shown on the right.
The text is now shown at exactly the same place regardless of which side
the portrait is on.

Fixes wesnoth#1938.

@sevu sevu added this to the 1.14.5 milestone Sep 15, 2018

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018

WML [message]: Add left padding when the portrait is shown on the right.
The text is now shown at exactly the same place regardless of which side
the portrait is on.

Fixes wesnoth#1938.

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018

WML [message]: Add left padding when the portrait is shown on the right.
The text is now shown at exactly the same place regardless of which side
the portrait is on.

Fixes wesnoth#1938.

(cherry-picked from commit fc9e5f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment