New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining and leaving an MP game leaves it in weird state #2040

Closed
Arcanister opened this Issue Sep 25, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@Arcanister
Contributor

Arcanister commented Sep 25, 2017

Behavior noticed with current master. Steps to reproduce:

  • have somebody else create normal 2-player MP game.
  • Join this game
  • Leave game
  • Join again, as observer (normal join won't work)

Problems arising from that:

  • You are still listed as player, while you are observer
  • Teamname for your former team becomes untranslated and is displayed as "teamname^South"
  • Esc key drops game to main screen instead of just leaving the game
  • Random gender icon now displays "null" tool-tip, if you hover mouse over it. Normally it doesn't display any tooltips (probably should display "random"), unlike explicitly selected genders icons.
@gfgtdf

This comment has been minimized.

Show comment
Hide comment
@gfgtdf

gfgtdf Sep 25, 2017

Contributor

This could happen if you connect to a server that was build before 8abb21e

Contributor

gfgtdf commented Sep 25, 2017

This could happen if you connect to a server that was build before 8abb21e

@Wedge009 Wedge009 added Bug MP labels Sep 26, 2017

@gfgtdf gfgtdf added the Regression label Sep 30, 2017

@gfgtdf

This comment has been minimized.

Show comment
Hide comment
@gfgtdf

gfgtdf Sep 30, 2017

Contributor

the server was rebuild so the main isue is fixed, mp ui issues are still there.

Contributor

gfgtdf commented Sep 30, 2017

the server was rebuild so the main isue is fixed, mp ui issues are still there.

@gfgtdf gfgtdf added the MP Lobby label Sep 30, 2017

Vultraz added a commit that referenced this issue Feb 6, 2018

Vultraz added a commit that referenced this issue Feb 6, 2018

MP Join Game: don't show "null" as gender tooltip
The gender handling needs some refactoring, but this is a quick fix to the immediately
noticeable issue. Fixes last item in #2040.
@Vultraz

This comment has been minimized.

Show comment
Hide comment
@Vultraz

Vultraz Feb 6, 2018

Member

Remaining items fixed by the commits above.

Member

Vultraz commented Feb 6, 2018

Remaining items fixed by the commits above.

@Vultraz Vultraz closed this Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment