New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wmlscope doesn't handle multiple files in single line if they have frame duration specified #2045

Closed
Arcanister opened this Issue Sep 26, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@Arcanister
Contributor

Arcanister commented Sep 26, 2017

When you run wmlscope --unresolved wesnoth/data/core you get multiple false positives such as:

"units/elves/Shaman.cfg", line 73: Unresolved reference -> 225,units/elves-wood/shaman.png
"units/elves/Shaman.cfg", line 74: Unresolved reference -> 75,halo/elven/nature-halo7.png
"units/elves/Shaman.cfg", line 74: Unresolved reference -> 75,halo/elven/nature-halo8.png

The code in place looks like:

[frame]
    image="units/elves-wood/shaman.png:225,units/elves-wood/shaman-attack2.png:225,units/elves-wood/shaman.png:100"
    halo=halo/elven/nature-halo[1~6].png:75,halo/elven/nature-halo[7~8].png:50
    halo_x,halo_y=0,-12
[/frame]

So it seems that wmlscope doesn't recognize frame durations.

@gfgtdf gfgtdf added the WML Tools label Sep 28, 2017

@CelticMinstrel

This comment has been minimized.

Show comment
Hide comment
@CelticMinstrel

CelticMinstrel Oct 1, 2017

Member

Why does the name of this issue have nothing to do with the content?

Member

CelticMinstrel commented Oct 1, 2017

Why does the name of this issue have nothing to do with the content?

@Arcanister Arcanister changed the title from wmlscope doesn't handle multiple files in single line to wmlscope doesn't handle multiple files in single line if they have frame duration specified Oct 1, 2017

@AI0867 AI0867 closed this in 3b203cb Oct 15, 2017

AI0867 added a commit that referenced this issue Oct 15, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Teach wmlscope to ignore frame durations. Fixes #2045
Former-commit-id: de7333b4a2fd3a044dc80f70b53930f89991e784

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Teach wmlscope to ignore frame durations. Fixes #2045
Former-commit-id: de7333b4a2fd3a044dc80f70b53930f89991e784
Former-commit-id: 46e20f5d3bb6e9105610710a162b604c3ee776d1

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Teach wmlscope to ignore frame durations. Fixes #2045
Former-commit-id: de7333b4a2fd3a044dc80f70b53930f89991e784
Former-commit-id: 46e20f5d3bb6e9105610710a162b604c3ee776d1
Former-commit-id: 71fc040c26c040d85318ddfdfb6bb1f17a24ad8a

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Teach wmlscope to ignore frame durations. Fixes #2045
Former-commit-id: de7333b4a2fd3a044dc80f70b53930f89991e784
Former-commit-id: 46e20f5d3bb6e9105610710a162b604c3ee776d1
Former-commit-id: 71fc040c26c040d85318ddfdfb6bb1f17a24ad8a

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Teach wmlscope to ignore frame durations. Fixes #2045
Former-commit-id: de7333b4a2fd3a044dc80f70b53930f89991e784
Former-commit-id: 46e20f5d3bb6e9105610710a162b604c3ee776d1
Former-commit-id: 71fc040c26c040d85318ddfdfb6bb1f17a24ad8a

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Teach wmlscope to ignore frame durations. Fixes #2045
Former-commit-id: de7333b4a2fd3a044dc80f70b53930f89991e784
Former-commit-id: 46e20f5d3bb6e9105610710a162b604c3ee776d1
Former-commit-id: 71fc040c26c040d85318ddfdfb6bb1f17a24ad8a

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Teach wmlscope to ignore frame durations. Fixes #2045
Former-commit-id: de7333b4a2fd3a044dc80f70b53930f89991e784
Former-commit-id: 46e20f5d3bb6e9105610710a162b604c3ee776d1
Former-commit-id: 71fc040c26c040d85318ddfdfb6bb1f17a24ad8a

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 2, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 6, 2017

Teach wmlscope to ignore frame durations. Fixes #2045
Former-commit-id: de7333b4a2fd3a044dc80f70b53930f89991e784
Former-commit-id: 46e20f5d3bb6e9105610710a162b604c3ee776d1
Former-commit-id: 71fc040c26c040d85318ddfdfb6bb1f17a24ad8a

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 6, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 6, 2017

Teach wmlscope to ignore frame durations. Fixes #2045
Former-commit-id: de7333b4a2fd3a044dc80f70b53930f89991e784
Former-commit-id: 46e20f5d3bb6e9105610710a162b604c3ee776d1
Former-commit-id: 71fc040c26c040d85318ddfdfb6bb1f17a24ad8a
Former-commit-id: 1bc36335e1125b93591ab2320755212cfa38ec6e [formerly aadbbcf5efa371cb63a298f926428fc0570ae78c]
Former-commit-id: ef24ad3e7bfaacb273ba56c9483860b06b88e2db

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 6, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275
Former-commit-id: 6894f399e6344ecc8b4ddd2fafeaf465a47ab1ca [formerly 086754cd6a7c8f9a3f6fdc9fd5f6e23c106d7418]
Former-commit-id: 1a87a38c294f263cb2a938ce9681edc6db608549

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 6, 2017

Teach wmlscope to ignore frame durations. Fixes #2045
Former-commit-id: de7333b4a2fd3a044dc80f70b53930f89991e784
Former-commit-id: 46e20f5d3bb6e9105610710a162b604c3ee776d1
Former-commit-id: 71fc040c26c040d85318ddfdfb6bb1f17a24ad8a
Former-commit-id: 1bc36335e1125b93591ab2320755212cfa38ec6e [formerly aadbbcf5efa371cb63a298f926428fc0570ae78c]
Former-commit-id: ef24ad3e7bfaacb273ba56c9483860b06b88e2db

fendrin pushed a commit to fendrin/wesnoth-src that referenced this issue Nov 6, 2017

Merge pull request #2053 from AI0867/wmlscope-durations
Teach wmlscope to ignore frame durations. Fixes #2045

Former-commit-id: e1207d87eaf2ba749798f3e418a521f837138bf2
Former-commit-id: 01a28adc12233e7cb91de739769483bee919a8ac
Former-commit-id: fdbe7130dcc7eef16d0a22ac0a3eb85b6c168275
Former-commit-id: 6894f399e6344ecc8b4ddd2fafeaf465a47ab1ca [formerly 086754cd6a7c8f9a3f6fdc9fd5f6e23c106d7418]
Former-commit-id: 1a87a38c294f263cb2a938ce9681edc6db608549

GregoryLundberg added a commit that referenced this issue Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment