New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Ctrl-F to go to Full screen and back renders wesnoth window blank #2050

Closed
Arcanister opened this Issue Sep 28, 2017 · 9 comments

Comments

Projects
None yet
4 participants
@Arcanister
Contributor

Arcanister commented Sep 28, 2017

X11, GNU/Linux, SDL 2.0.5.

Steps to reproduce:

  1. Start Wesnoth in windowed mode
  2. Press Ctrl-F from main screen
  3. Press again
  4. Wesnoth goes back to windowed mode, but its window is filled with black and no controls or anything are visible.

Hovering mouse around reveal button one by one and eventually window is redrawn and all content goes back in place. Sometimes windows goes all black while in fullscreen mode too.

@GregoryLundberg

This comment has been minimized.

Show comment
Hide comment
@GregoryLundberg

GregoryLundberg Sep 28, 2017

Contributor

Cannot reproduce the blank/black screen. I see it go black but repaint properly a moment later.

I am seeing random crashes using the steps above;

[lundberg@lundberg-arch ~]$ ./wesnoth/wesnoth
Battle for Wesnoth v1.13.10 (3df86a0f6c-Clean)
Started on Thu Sep 28 12:12:27 2017

Automatically found a possible data directory at /home/lundberg/wesnoth

Data directory:               /home/lundberg/wesnoth
User configuration directory: /home/lundberg/.config/wesnoth
User data directory:          /home/lundberg/.local/share/wesnoth/1.13
Cache directory:              /home/lundberg/.cache/wesnoth

Setting mode to 1440x845
Checking lua scripts... ok
Segmentation fault (core dumped)
[lundberg@lundberg-arch ~]$ ./wesnoth/wesnoth
Battle for Wesnoth v1.13.10 (3df86a0f6c-Clean)
Started on Thu Sep 28 12:13:06 2017

Automatically found a possible data directory at /home/lundberg/wesnoth

Data directory:               /home/lundberg/wesnoth
User configuration directory: /home/lundberg/.config/wesnoth
User data directory:          /home/lundberg/.local/share/wesnoth/1.13
Cache directory:              /home/lundberg/.cache/wesnoth

Setting mode to 800x600
Checking lua scripts... ok
*** Error in `./wesnoth/wesnoth': free(): invalid pointer: 0x00007f91b9421000 ***
Aborted (core dumped)

Contributor

GregoryLundberg commented Sep 28, 2017

Cannot reproduce the blank/black screen. I see it go black but repaint properly a moment later.

I am seeing random crashes using the steps above;

[lundberg@lundberg-arch ~]$ ./wesnoth/wesnoth
Battle for Wesnoth v1.13.10 (3df86a0f6c-Clean)
Started on Thu Sep 28 12:12:27 2017

Automatically found a possible data directory at /home/lundberg/wesnoth

Data directory:               /home/lundberg/wesnoth
User configuration directory: /home/lundberg/.config/wesnoth
User data directory:          /home/lundberg/.local/share/wesnoth/1.13
Cache directory:              /home/lundberg/.cache/wesnoth

Setting mode to 1440x845
Checking lua scripts... ok
Segmentation fault (core dumped)
[lundberg@lundberg-arch ~]$ ./wesnoth/wesnoth
Battle for Wesnoth v1.13.10 (3df86a0f6c-Clean)
Started on Thu Sep 28 12:13:06 2017

Automatically found a possible data directory at /home/lundberg/wesnoth

Data directory:               /home/lundberg/wesnoth
User configuration directory: /home/lundberg/.config/wesnoth
User data directory:          /home/lundberg/.local/share/wesnoth/1.13
Cache directory:              /home/lundberg/.cache/wesnoth

Setting mode to 800x600
Checking lua scripts... ok
*** Error in `./wesnoth/wesnoth': free(): invalid pointer: 0x00007f91b9421000 ***
Aborted (core dumped)

@Arcanister

This comment has been minimized.

Show comment
Hide comment
@Arcanister

Arcanister Sep 28, 2017

Contributor

What SDL version do you use?

Contributor

Arcanister commented Sep 28, 2017

What SDL version do you use?

@GregoryLundberg

This comment has been minimized.

Show comment
Hide comment
@GregoryLundberg

GregoryLundberg Sep 28, 2017

Contributor
[lundberg@lundberg-arch ~]$ yaourt -Q sdl2
extra/sdl2 2.0.6-1

Contributor

GregoryLundberg commented Sep 28, 2017

[lundberg@lundberg-arch ~]$ yaourt -Q sdl2
extra/sdl2 2.0.6-1

@Arcanister

This comment has been minimized.

Show comment
Hide comment
@Arcanister

Arcanister Sep 28, 2017

Contributor

I think it could be related with dbd6695 and following commits. Though without them you would get crashes immediately after starting wesnoth with SDL 2.0.6.

Contributor

Arcanister commented Sep 28, 2017

I think it could be related with dbd6695 and following commits. Though without them you would get crashes immediately after starting wesnoth with SDL 2.0.6.

@Wedge009

This comment has been minimized.

Show comment
Hide comment
@Wedge009

Wedge009 Sep 29, 2017

Member

I only get the issue in Linux, and I'm still running SDL 2.0.5. Flipping between window and full-screen, I alternate between this black screen issue and #2035. There may be a connection there. Maybe with #2041 as well.

Windows build does not exhibit any of the wrong dimensions behaviour, though it may temporarily black-out for a redraw. Experience in Windows is much smoother.

Member

Wedge009 commented Sep 29, 2017

I only get the issue in Linux, and I'm still running SDL 2.0.5. Flipping between window and full-screen, I alternate between this black screen issue and #2035. There may be a connection there. Maybe with #2041 as well.

Windows build does not exhibit any of the wrong dimensions behaviour, though it may temporarily black-out for a redraw. Experience in Windows is much smoother.

@Wedge009 Wedge009 added the Graphics label Sep 29, 2017

@Arcanister

This comment has been minimized.

Show comment
Hide comment
@Arcanister

Arcanister Sep 29, 2017

Contributor

In both cases Wesnoth window doesn't redraw properly immediately after changing state.
Behavior between Ctrl-F and Check-box differ though, I don't get black screen with checkbox. Either it's because when using mouse to click it causes additional window events, or code which handles Ctrl-F is different from code which handles checkbox in Wesnoth.

There is also another related problem:
Coming to fullscreen using wesnoth built-in ways (-f in command line, ctrl-f key or checkbox) causes screen to go black in some window managers, namely xmonad, while triggering fullscreen mode from xmonad itself works.

Contributor

Arcanister commented Sep 29, 2017

In both cases Wesnoth window doesn't redraw properly immediately after changing state.
Behavior between Ctrl-F and Check-box differ though, I don't get black screen with checkbox. Either it's because when using mouse to click it causes additional window events, or code which handles Ctrl-F is different from code which handles checkbox in Wesnoth.

There is also another related problem:
Coming to fullscreen using wesnoth built-in ways (-f in command line, ctrl-f key or checkbox) causes screen to go black in some window managers, namely xmonad, while triggering fullscreen mode from xmonad itself works.

@Wedge009

This comment has been minimized.

Show comment
Hide comment
@Wedge009

Wedge009 Sep 29, 2017

Member

The similarity is with respect to the underlying graphical problem, not the method of switching to/from full-screen. It seems to me that finding and resolving the cause for one will resolve it for the other, so until we know otherwise I would consider these two symptoms to be the same issue.

I'd agree with the idea that the mouse-click events may cause some additional interaction avoiding the black-out issue.

Member

Wedge009 commented Sep 29, 2017

The similarity is with respect to the underlying graphical problem, not the method of switching to/from full-screen. It seems to me that finding and resolving the cause for one will resolve it for the other, so until we know otherwise I would consider these two symptoms to be the same issue.

I'd agree with the idea that the mouse-click events may cause some additional interaction avoiding the black-out issue.

@Pentarctagon

This comment has been minimized.

Show comment
Hide comment
@Pentarctagon

Pentarctagon Sep 29, 2017

Member

I can't reproduce this on Linux either. Wesnoth info: https://i.imgur.com/C4Y2BSn.png

Member

Pentarctagon commented Sep 29, 2017

I can't reproduce this on Linux either. Wesnoth info: https://i.imgur.com/C4Y2BSn.png

@Wedge009

This comment has been minimized.

Show comment
Hide comment
@Wedge009

Wedge009 Oct 14, 2017

Member

As agreed with @CelticMinstrel, closing this as duplicate of #2035 and #2041.

Member

Wedge009 commented Oct 14, 2017

As agreed with @CelticMinstrel, closing this as duplicate of #2035 and #2041.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment