New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake map border broken with sdl 2.0.6+ #2061

Closed
sevu opened this Issue Oct 1, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@sevu
Member

sevu commented Oct 1, 2017

bildschirmfoto der karte_003
The offmap terrain is as well affected.
I assume the reason is the switch to sdl2.0.6, since this changed recently.

Tested with current master and dbd6695. The recent commits by Doofus are not related.
Can someone confirm this not happening with sdl 2.0.5? I uploaded the map here.

@Pentarctagon

This comment has been minimized.

Show comment
Hide comment
@Pentarctagon

Pentarctagon Oct 1, 2017

Member

This does not happen for me in the map editor with SDL 2.0.5, on Mint 18.2.

I also tried loading this through Multiplayer > Local Game > User Maps, and it was... strange. I've opened another issue for that though.

Member

Pentarctagon commented Oct 1, 2017

This does not happen for me in the map editor with SDL 2.0.5, on Mint 18.2.

I also tried loading this through Multiplayer > Local Game > User Maps, and it was... strange. I've opened another issue for that though.

@Arcanister

This comment has been minimized.

Show comment
Hide comment
@Arcanister

Arcanister Oct 1, 2017

Contributor

I can confirm that Wesnoth with SDL 2.0.6 has this problem, and 2.0.5 has not. OS is GNU/Linux (X11), wesnoth binary same.

I have noticed similar map edge problems when trying to play To Land Unknown with Wesnoth 1.13 (normally it's not available here), even when SDL was 2.0.4. I didn't recheck with 2.0.5 or 2.0.6 though.

Contributor

Arcanister commented Oct 1, 2017

I can confirm that Wesnoth with SDL 2.0.6 has this problem, and 2.0.5 has not. OS is GNU/Linux (X11), wesnoth binary same.

I have noticed similar map edge problems when trying to play To Land Unknown with Wesnoth 1.13 (normally it's not available here), even when SDL was 2.0.4. I didn't recheck with 2.0.5 or 2.0.6 though.

@sevu

This comment has been minimized.

Show comment
Hide comment
@sevu

sevu Oct 18, 2017

Member

When you zoom (with +), graphics are displayed the same as they used to be before 2.0.6.

Member

sevu commented Oct 18, 2017

When you zoom (with +), graphics are displayed the same as they used to be before 2.0.6.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 19, 2017

Yo!

You could test and see if this is fixed in the SDL 2.0.7 prerelease.

zonkmachine commented Oct 19, 2017

Yo!

You could test and see if this is fixed in the SDL 2.0.7 prerelease.

@sevu

This comment has been minimized.

Show comment
Hide comment
@sevu

sevu Oct 26, 2017

Member

Happens still with 2.0.7

Member

sevu commented Oct 26, 2017

Happens still with 2.0.7

@Wedge009

This comment has been minimized.

Show comment
Hide comment
@Wedge009

Wedge009 Oct 27, 2017

Member

As noted in #2131 this seems to occur in Aethermaw as well.

Member

Wedge009 commented Oct 27, 2017

As noted in #2131 this seems to occur in Aethermaw as well.

@Vultraz Vultraz changed the title from fake map border broken with sdl 2.0.6 to fake map border broken with sdl 2.0.6+ Oct 29, 2017

@Vultraz Vultraz closed this in 976f37c Nov 21, 2017

@Wedge009

This comment has been minimized.

Show comment
Hide comment
@Wedge009

Wedge009 Nov 21, 2017

Member

@Vultraz Seems to do the trick. Funny thing about the alpha layer.

Member

Wedge009 commented Nov 21, 2017

@Vultraz Seems to do the trick. Funny thing about the alpha layer.

GregoryLundberg added a commit that referenced this issue Nov 30, 2017

Fixed graphical artifacts appearing in Fake Map Border/Off Map terrai…
…ns with SDL 2.0.6+ (fixes #2061)

[ci skip]

Something was screwy about these image's alpha. Normally when I remove an alpha channel in GIMP,
it shows up white. With these images, it showed up black. Maybe they had an embedded palette or
something, I don't know, but the problem is fixed.

Something must have changed in SDL 2.0.6 that caused this issue to appear. Not sure if anything
needs to be patched in our source code, though (but not likely)

GregoryLundberg added a commit that referenced this issue Nov 30, 2017

Fixed graphical artifacts appearing in Fake Map Border/Off Map terrai…
…ns with SDL 2.0.6+ (fixes #2061)

[ci skip]

Something was screwy about these image's alpha. Normally when I remove an alpha channel in GIMP,
it shows up white. With these images, it showed up black. Maybe they had an embedded palette or
something, I don't know, but the problem is fixed.

Something must have changed in SDL 2.0.6 that caused this issue to appear. Not sure if anything
needs to be patched in our source code, though (but not likely)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment