Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depcheck prompts for era selection when selecting mods in SP #2229

Closed
Vultraz opened this issue Nov 22, 2017 · 6 comments
Closed

Depcheck prompts for era selection when selecting mods in SP #2229

Vultraz opened this issue Nov 22, 2017 · 6 comments
Assignees
Labels
Bug Issues involving unexpected behavior. UI User interface issues, including both back-end and front-end issues.
Milestone

Comments

@Vultraz
Copy link
Member

Vultraz commented Nov 22, 2017

See title. When you toggle a mod (both select and deselect are affected) in the SP campaign selection dialog, a prompt appears telling you you need to choose a compatible era and offers the Default era as the only choice.

@Vultraz Vultraz added Bug Issues involving unexpected behavior. Regression Issues that were not present in previous releases. labels Nov 22, 2017
@gfgtdf
Copy link
Contributor

gfgtdf commented Nov 24, 2017

hmm yes this sounds like a problem. Disabling the depcheck for sp would probably be rather easy, but i think that depcheck might be useful in sp too. For example if a mod is known not to work with a certain campaign the author of the mod could specifically disallow the mod for that one... then again prroperly enabling depcheck for sp woudl requite fixing the select campaign gui code aswell whihc i'm currently not moptivated to so, i'm probably just going for disable it for sp.

also i removed the regression label since it's not a regression compares to 1.12 (since that one didnt't support mods for sp)

@gfgtdf gfgtdf removed the Regression Issues that were not present in previous releases. label Nov 24, 2017
@Vultraz
Copy link
Member Author

Vultraz commented Nov 24, 2017

What UI changes need to be made?

@gfgtdf
Copy link
Contributor

gfgtdf commented Nov 24, 2017

what i meant was just that the code in gui/dialogs/campaign_selection.hpp neds to be changed to change ui buttons/listsbox state accoridingly if the depcheck reverted a human made decision, (instead of just changing depcheck/create_engine whihc might be enough to fix this partcular issue but wouldn't make depcgheck work properly in sp)

@gfgtdf gfgtdf added this to the 1.14.0 milestone Dec 24, 2017
@gfgtdf gfgtdf added the Blocker: New Stable Issues that must be resolved prior to the next stable series being released. label Dec 27, 2017
gfgtdf added a commit that referenced this issue Feb 25, 2018
this is not the best fix for #2229 (Depcheck prompts for era selection when selecting mods in SP). Is basicially partly reverts 2f1c1e3#diff-0c76da729be4efff30ec9e40d29677b8 which also removed these checks.

Of course it would be much better if we actually manage to get the depcheck working in sp, this would require a somw work in gui/dialogs/campaign_selection.cpp to change ui the buttons/listsbox state accoridingly whenever the depcheck reverted a humanmade decision. Similar to what i impelemented in 2f1c1e3 for mp_create_game.cpp
@jyrkive
Copy link
Member

jyrkive commented Feb 25, 2018

With dependency check disabled in SP, this is no longer a blocker.

@jyrkive jyrkive removed the Blocker: New Stable Issues that must be resolved prior to the next stable series being released. label Feb 25, 2018
@CelticMinstrel
Copy link
Member

I noticed recently that the default era has type=hybrid. That might explain why the depcheck is offering only that era. Of course, that doesn't really help the situation, as you're not supposed to be picking an era here anyway.

@CelticMinstrel CelticMinstrel added the UI User interface issues, including both back-end and front-end issues. label Feb 25, 2018
@gfgtdf
Copy link
Contributor

gfgtdf commented Feb 25, 2018

With dependency check disabled in SP, this is no longer a blocker.

Ye, my actual plan was to close this one and open a new issue for the current state

I noticed recently that the default era has type=hybrid. That might explain why the depcheck is offering only that era. Of course, that doesn't really help the situation, as you're not supposed to be picking an era here anyway.

yes the the problem is not the only one selection is offered, it's that that dialog is shoiwn in the first place. The default era shoudl already be selected be default (since it is the only era) iirc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Development

No branches or pull requests

4 participants