New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depcheck prompts for era selection when selecting mods in SP #2229
Comments
hmm yes this sounds like a problem. Disabling the depcheck for sp would probably be rather easy, but i think that depcheck might be useful in sp too. For example if a mod is known not to work with a certain campaign the author of the mod could specifically disallow the mod for that one... then again prroperly enabling depcheck for sp woudl requite fixing the select campaign gui code aswell whihc i'm currently not moptivated to so, i'm probably just going for disable it for sp. also i removed the regression label since it's not a regression compares to 1.12 (since that one didnt't support mods for sp) |
What UI changes need to be made? |
what i meant was just that the code in gui/dialogs/campaign_selection.hpp neds to be changed to change ui buttons/listsbox state accoridingly if the depcheck reverted a human made decision, (instead of just changing depcheck/create_engine whihc might be enough to fix this partcular issue but wouldn't make depcgheck work properly in sp) |
this is not the best fix for #2229 (Depcheck prompts for era selection when selecting mods in SP). Is basicially partly reverts 2f1c1e3#diff-0c76da729be4efff30ec9e40d29677b8 which also removed these checks. Of course it would be much better if we actually manage to get the depcheck working in sp, this would require a somw work in gui/dialogs/campaign_selection.cpp to change ui the buttons/listsbox state accoridingly whenever the depcheck reverted a humanmade decision. Similar to what i impelemented in 2f1c1e3 for mp_create_game.cpp
With dependency check disabled in SP, this is no longer a blocker. |
I noticed recently that the default era has |
Ye, my actual plan was to close this one and open a new issue for the current state
yes the the problem is not the only one selection is offered, it's that that dialog is shoiwn in the first place. The default era shoudl already be selected be default (since it is the only era) iirc. |
See title. When you toggle a mod (both select and deselect are affected) in the SP campaign selection dialog, a prompt appears telling you you need to choose a compatible era and offers the Default era as the only choice.
The text was updated successfully, but these errors were encountered: